----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7958/#review13289 -----------------------------------------------------------
Some initial comments. Regarding the google client jars - i think there's no need to add them as WIAB already has them. ./src/com/google/wave/api/WaveService.java <https://reviews.apache.org/r/7958/#comment28547> Why use this additional field? ./src/com/google/wave/api/WaveService.java <https://reviews.apache.org/r/7958/#comment28549> Usually methods that start with "get" and "set" are reserved for gettera/setters. Can we rename this method to retrieveWaveletIds since this is not a simple getter, but there's RPC request issued on each method invocation. ./src/com/google/wave/api/WaveService.java <https://reviews.apache.org/r/7958/#comment28548> Export -> Exports ./src/org/waveprotocol/box/server/robots/operations/ExportDeltasService.java <https://reviews.apache.org/r/7958/#comment28585> Can we change the name to GET_HISTORY_TIMEOUT_MS and remove the comment? ./src/org/waveprotocol/box/server/robots/operations/ExportDeltasService.java <https://reviews.apache.org/r/7958/#comment28586> Remove space ./src/org/waveprotocol/box/server/robots/operations/ImportDeltasService.java <https://reviews.apache.org/r/7958/#comment28587> Set -> Sets ./src/org/waveprotocol/box/server/robots/operations/ImportDeltasService.java <https://reviews.apache.org/r/7958/#comment28588> @param delta source delta -> the source delat. ./src/org/waveprotocol/box/server/robots/operations/ImportDeltasService.java <https://reviews.apache.org/r/7958/#comment28589> Please terminate the doc with full stop. ./src/org/waveprotocol/box/server/robots/operations/ImportDeltasService.java <https://reviews.apache.org/r/7958/#comment28590> -> the delta to import ./src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java <https://reviews.apache.org/r/7958/#comment28593> There's already method with the same name that does similar thing. Can we re-use the existing code? Also, what is the use of "timeout" here? ./src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java <https://reviews.apache.org/r/7958/#comment28591> remove space ./src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java <https://reviews.apache.org/r/7958/#comment28592> Add space before and after + ./src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java <https://reviews.apache.org/r/7958/#comment28594> Same here, can we re-use existing code? ./src/org/waveprotocol/box/server/waveserver/WaveServerImpl.java <https://reviews.apache.org/r/7958/#comment28595> Code re-use? ./src/org/waveprotocol/box/server/waveserver/WaveletContainer.java <https://reviews.apache.org/r/7958/#comment28596> Code re-use? ./src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java <https://reviews.apache.org/r/7958/#comment28597> Code re-use? ./src/org/waveprotocol/wave/model/image/ImageConstants.java <https://reviews.apache.org/r/7958/#comment28598> Remove empty line - Yuri Zelikov On Nov. 8, 2012, 9:28 a.m., Andrew Kaplanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7958/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2012, 9:28 a.m.) > > > Review request for wave and Yuri Zelikov. > > > Description > ------- > > Export/Import client utilities and support on the server. > Replaces utilities for export from GWave and import to Wiab. > Released on DataAPI and RobotAPI. > See README.export-import for tutorial. > > > Diffs > ----- > > ./README.export-import PRE-CREATION > ./README.import 1406525 > ./build.properties 1406525 > ./build.xml 1406525 > ./run-export.sh 1406525 > ./run-import.sh 1406525 > ./server-config.xml 1406525 > ./server.config.example 1406525 > ./src/com/google/wave/api/JsonRpcConstant.java 1406525 > ./src/com/google/wave/api/OperationQueue.java 1406525 > ./src/com/google/wave/api/OperationType.java 1406525 > ./src/com/google/wave/api/WaveService.java 1406525 > ./src/com/google/wave/api/event/WaveletFetchedEvent.java 1406525 > ./src/com/google/wave/api/impl/AttachmentData.java PRE-CREATION > ./src/com/google/wave/api/impl/GsonFactory.java 1406525 > ./src/com/google/wave/api/impl/JsonRpcResponseGsonAdaptor.java 1406525 > ./src/com/google/wave/api/impl/RawDeltas.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/Console.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/DeltaParser.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/DomainConverter.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/FileNames.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/OAuth.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/WaveExport.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/WaveImport.java PRE-CREATION > ./src/org/waveprotocol/box/server/CoreSettings.java 1406525 > ./src/org/waveprotocol/box/server/ServerMain.java 1406525 > ./src/org/waveprotocol/box/server/gxp/OAuthAuthorizationCodePage.gxp > PRE-CREATION > ./src/org/waveprotocol/box/server/gxp/OAuthAuthorizeTokenPage.gxp 1406525 > ./src/org/waveprotocol/box/server/robots/OperationContext.java 1406525 > ./src/org/waveprotocol/box/server/robots/OperationContextImpl.java 1406525 > ./src/org/waveprotocol/box/server/robots/RobotApiModule.java 1406525 > > ./src/org/waveprotocol/box/server/robots/active/ActiveApiOperationServiceRegistry.java > 1406525 > ./src/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServlet.java > 1406525 > > ./src/org/waveprotocol/box/server/robots/dataapi/DataApiOperationServiceRegistry.java > 1406525 > > ./src/org/waveprotocol/box/server/robots/operations/ExportAttachmentService.java > PRE-CREATION > > ./src/org/waveprotocol/box/server/robots/operations/ExportDeltasService.java > PRE-CREATION > > ./src/org/waveprotocol/box/server/robots/operations/ExportSnapshotService.java > PRE-CREATION > ./src/org/waveprotocol/box/server/robots/operations/FetchWaveService.java > 1406525 > > ./src/org/waveprotocol/box/server/robots/operations/ImportAttachmentService.java > PRE-CREATION > > ./src/org/waveprotocol/box/server/robots/operations/ImportDeltasService.java > PRE-CREATION > > ./src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java > 1406525 > ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java 1406525 > ./src/org/waveprotocol/box/server/waveserver/WaveServerImpl.java 1406525 > ./src/org/waveprotocol/box/server/waveserver/WaveletContainer.java 1406525 > ./src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java > 1406525 > ./src/org/waveprotocol/box/server/waveserver/WaveletProvider.java 1406525 > ./src/org/waveprotocol/box/server/waveserver/WaveletState.java 1406525 > ./src/org/waveprotocol/box/waveimport/WaveExport.java 1406525 > ./src/org/waveprotocol/box/waveimport/WaveImport.java 1406525 > ./src/org/waveprotocol/box/waveimport/google/RobotApi.java 1406525 > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigest.java 1406525 > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestGsonImpl.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestImpl.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestUtil.java > 1406525 > > ./src/org/waveprotocol/box/waveimport/google/oauth/NeedNewOAuthTokenException.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthCredentials.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthRequestHelper.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthedFetchService.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/oauth/StableUserId.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/oauth/UserContext.java 1406525 > ./src/org/waveprotocol/wave/model/image/ImageConstants.java PRE-CREATION > ./test/org/waveprotocol/box/expimp/DomainConverterTest.java PRE-CREATION > > ./test/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServletTest.java > 1406525 > ./test/org/waveprotocol/box/server/rpc/WaveletProviderStub.java 1406525 > ./test/org/waveprotocol/box/server/waveserver/ImportServletTest.java > 1406525 > ./third_party/runtime/google-api-client/COPYING 1406525 > ./third_party/runtime/google-api-client/README 1406525 > ./third_party/runtime/google-api-client/google-api-client-1.5.0-beta.jar > 1406525 > ./third_party/runtime/google-api-client/google-http-client-1.5.0-beta.jar > 1406525 > ./third_party/runtime/google-api-client/google-oauth-client-1.5.0-beta.jar > 1406525 > > Diff: https://reviews.apache.org/r/7958/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Kaplanov > >
