> On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > Some initial comments. > > Regarding the google client jars - i think there's no need to add them as > > WIAB already has them.
Google client jars are removed as unused. > On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/com/google/wave/api/WaveService.java, line 89 > > <https://reviews.apache.org/r/7958/diff/2/?file=186881#file186881line89> > > > > Why use this additional field? To can redefine default timeout value; > On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java, > > line 398 > > <https://reviews.apache.org/r/7958/diff/2/?file=186910#file186910line398> > > > > Same here, can we re-use existing code? I believe that it is wrong to break the implementation of core functions in order to bring them to the requirements of export. This refers to use versions of primitive long type without hash and specify a timeout for the operation. Maybe I'm wrong, but I see this option as safely as possible. > On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/server/waveserver/WaveServerImpl.java, line 300 > > <https://reviews.apache.org/r/7958/diff/2/?file=186912#file186912line300> > > > > Code re-use? Same. > On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/server/waveserver/WaveletContainer.java, line 102 > > <https://reviews.apache.org/r/7958/diff/2/?file=186913#file186913line102> > > > > Code re-use? Same. > On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java, > > line 513 > > <https://reviews.apache.org/r/7958/diff/2/?file=186914#file186914line513> > > > > Code re-use? Same. > On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote: > > ./src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java, > > line 157 > > <https://reviews.apache.org/r/7958/diff/2/?file=186910#file186910line157> > > > > There's already method with the same name that does similar thing. Can > > we re-use the existing code? > > Also, what is the use of "timeout" here? See below. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7958/#review13289 ----------------------------------------------------------- On Nov. 8, 2012, 9:28 a.m., Andrew Kaplanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7958/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2012, 9:28 a.m.) > > > Review request for wave and Yuri Zelikov. > > > Description > ------- > > Export/Import client utilities and support on the server. > Replaces utilities for export from GWave and import to Wiab. > Released on DataAPI and RobotAPI. > See README.export-import for tutorial. > > > Diffs > ----- > > ./README.export-import PRE-CREATION > ./README.import 1406525 > ./build.properties 1406525 > ./build.xml 1406525 > ./run-export.sh 1406525 > ./run-import.sh 1406525 > ./server-config.xml 1406525 > ./server.config.example 1406525 > ./src/com/google/wave/api/JsonRpcConstant.java 1406525 > ./src/com/google/wave/api/OperationQueue.java 1406525 > ./src/com/google/wave/api/OperationType.java 1406525 > ./src/com/google/wave/api/WaveService.java 1406525 > ./src/com/google/wave/api/event/WaveletFetchedEvent.java 1406525 > ./src/com/google/wave/api/impl/AttachmentData.java PRE-CREATION > ./src/com/google/wave/api/impl/GsonFactory.java 1406525 > ./src/com/google/wave/api/impl/JsonRpcResponseGsonAdaptor.java 1406525 > ./src/com/google/wave/api/impl/RawDeltas.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/Console.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/DeltaParser.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/DomainConverter.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/FileNames.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/OAuth.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/WaveExport.java PRE-CREATION > ./src/org/waveprotocol/box/expimp/WaveImport.java PRE-CREATION > ./src/org/waveprotocol/box/server/CoreSettings.java 1406525 > ./src/org/waveprotocol/box/server/ServerMain.java 1406525 > ./src/org/waveprotocol/box/server/gxp/OAuthAuthorizationCodePage.gxp > PRE-CREATION > ./src/org/waveprotocol/box/server/gxp/OAuthAuthorizeTokenPage.gxp 1406525 > ./src/org/waveprotocol/box/server/robots/OperationContext.java 1406525 > ./src/org/waveprotocol/box/server/robots/OperationContextImpl.java 1406525 > ./src/org/waveprotocol/box/server/robots/RobotApiModule.java 1406525 > > ./src/org/waveprotocol/box/server/robots/active/ActiveApiOperationServiceRegistry.java > 1406525 > ./src/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServlet.java > 1406525 > > ./src/org/waveprotocol/box/server/robots/dataapi/DataApiOperationServiceRegistry.java > 1406525 > > ./src/org/waveprotocol/box/server/robots/operations/ExportAttachmentService.java > PRE-CREATION > > ./src/org/waveprotocol/box/server/robots/operations/ExportDeltasService.java > PRE-CREATION > > ./src/org/waveprotocol/box/server/robots/operations/ExportSnapshotService.java > PRE-CREATION > ./src/org/waveprotocol/box/server/robots/operations/FetchWaveService.java > 1406525 > > ./src/org/waveprotocol/box/server/robots/operations/ImportAttachmentService.java > PRE-CREATION > > ./src/org/waveprotocol/box/server/robots/operations/ImportDeltasService.java > PRE-CREATION > > ./src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java > 1406525 > ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java 1406525 > ./src/org/waveprotocol/box/server/waveserver/WaveServerImpl.java 1406525 > ./src/org/waveprotocol/box/server/waveserver/WaveletContainer.java 1406525 > ./src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java > 1406525 > ./src/org/waveprotocol/box/server/waveserver/WaveletProvider.java 1406525 > ./src/org/waveprotocol/box/server/waveserver/WaveletState.java 1406525 > ./src/org/waveprotocol/box/waveimport/WaveExport.java 1406525 > ./src/org/waveprotocol/box/waveimport/WaveImport.java 1406525 > ./src/org/waveprotocol/box/waveimport/google/RobotApi.java 1406525 > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigest.java 1406525 > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestGsonImpl.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestImpl.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestUtil.java > 1406525 > > ./src/org/waveprotocol/box/waveimport/google/oauth/NeedNewOAuthTokenException.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthCredentials.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthRequestHelper.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthedFetchService.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/oauth/StableUserId.java > 1406525 > ./src/org/waveprotocol/box/waveimport/google/oauth/UserContext.java 1406525 > ./src/org/waveprotocol/wave/model/image/ImageConstants.java PRE-CREATION > ./test/org/waveprotocol/box/expimp/DomainConverterTest.java PRE-CREATION > > ./test/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServletTest.java > 1406525 > ./test/org/waveprotocol/box/server/rpc/WaveletProviderStub.java 1406525 > ./test/org/waveprotocol/box/server/waveserver/ImportServletTest.java > 1406525 > ./third_party/runtime/google-api-client/COPYING 1406525 > ./third_party/runtime/google-api-client/README 1406525 > ./third_party/runtime/google-api-client/google-api-client-1.5.0-beta.jar > 1406525 > ./third_party/runtime/google-api-client/google-http-client-1.5.0-beta.jar > 1406525 > ./third_party/runtime/google-api-client/google-oauth-client-1.5.0-beta.jar > 1406525 > > Diff: https://reviews.apache.org/r/7958/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Kaplanov > >
