Hi Torben,

Cool, it's great to see more code out there, good effort on your part.

It might be worth comparing your transformation output against that of
the published java code (since you can compare at the level of
protobuffers). If you check out the random operation generator in the
FedOne repository, it might give you a good place to start.

It would also be important to verify that deltas that have been
applied to a wavelet will yield the same results as with the published
Java code. (again, you could use the random operation generator). If
necessary you can dump the text of a modified wavelet document from
both your code and the java code and do a diff ?

I was curious about the OT code, so I had a quick look at your
transform code. Unfortunately I don't have enough time right now to do a proper
review, here are 2 small points to ponder:

It looks like you don't check whether ops are from different documents
? 
http://code.google.com/p/qwaveclient/source/browse/trunk/model/documentmutation.cpp#761
see 
http://code.google.com/p/wave-protocol/source/browse/src/org/waveprotocol/wave/model/operation/Transform.java#54

What happens when a client submits at a version that is not the latest
version of the wavelet ?

good luck and thanks for the heads-up.

thanks,
Jochen
Software Engineer, Google Wave


On Thu, Jan 21, 2010 at 10:56 AM, Torben Weis <[email protected]> wrote:
> Hi,
> there is a new open-source wave server available written in C++ (I am a Java
> hater).
> Don't ask me why exactly I did this, but now it's there :-) You can find it
> in the QWaveClient svn (http://code.google.com/p/qwaveclient/) in the
> 'waveserver' folder. The server offers the same Client/Server protocol as
> FedOne. Thus, you can use it with FedOne console client or (of course)
> QWaveClient.
> The server supports OT (it uses the OT code from QWaveClient). I tested it a
> bit with QWaveClient and it seems that it can be used for waving already,
> but it is still rather untested. Currently it does not federate, but it can
> host multiple clients concurrently of course.
> So why should you care? Don't know. It might be a good starting point for
> C++ coders to work on a wave server and it might be helpful for wave to have
> more than one implementation up and running. I will use it for some
> experiments with a better Client/Server protocol. The FedOne development
> model does not lend itself to such a task at all and last not least did i
> mention that I don't like Java?
> Cheers
> Torben
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Wave Protocol" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to
> [email protected].
> For more options, visit this group at
> http://groups.google.com/group/wave-protocol?hl=en.
>
>
-- 
You received this message because you are subscribed to the Google Groups "Wave 
Protocol" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/wave-protocol?hl=en.


Reply via email to