Woohoo! Thanks Alex. One question though: did this blast away the revision history of the libraries repo? i.e., is there still any way to inspect the last month or two of changes to files that used to be in the libraries repo?
On Nov 22, 8:49 am, Alex North <[email protected]> wrote: > I am submitting this shortly. I'll disable the libraries repository and any > future changes should be made against default. > > On 19 November 2010 23:33, Alex North <[email protected]> wrote: > > > > > > > > > I have a change out for review merging the repositories: > >http://codereview.waveprotocol.org/354001 > > > If you have any outstanding changes to the libraries repo, or are planning > > to make any, please let me know so we can co-ordinate. I'd like to submit > > this change shortly so we can get on with cleaning up the build > > infrastructure etc. > > > A > > > On 18 November 2010 16:00, Alex North <[email protected]> wrote: > > >> Ok, I'm now happy that the libraries tests are fast. > > >> I'm now working on merging the repositories. It might take a little work > >> so don't let me stop you from making code changes, but I would appreciate > >> it > >> if everyone held off radical build file changes for a day or so. That's > >> where all the complexity is. > > >> Alex > > >> On 11 November 2010 12:16, Alex North <[email protected]> wrote: > > >>> WRT the test cases, my plan is to use a simple naming convention to split > >>> test cases > >>> - All GWT tests named *GwtTestCase > >>> - All "large" tests named *LargeTest > >>> - Everything else is just *Test > > >>> "Large" tests are slow (> 1 sec), or involve disk access, network > >>> traffic, etc. > > >>> I'm going to start a rename change now. > > >>> Later we could move to using Java reflection to build test suite > >>> builders, etc., but for now it doesn't seem worth that effort. > > >>> Alex > > >>> On 3 November 2010 18:39, Alex North <[email protected]> wrote: > > >>>> The libraries and default repositories in our code project are separate > >>>> for legacy reason we've been working to overcome. The libraries repo has > >>>> general, re-usable code and largely comprises code that formed the core > >>>> of > >>>> Google Wave. The default repository has what was an "example" application > >>>> but we're now building out to be a very real implementation. > > >>>> While the separation of generally re-usable code from the specifics of > >>>> the WIAB implementation is still informative, I don't think it warrants > >>>> the > >>>> overhead of maintaining a separate repository. We can express it in build > >>>> files, jars, etc. I propose we merge libraries into default. > > >>>> However, one thing we must resolve before doing so is to speed up the > >>>> tests in the libraries repo. The structure of the GWT tests there > >>>> results in > >>>> a ~30m test cycle, and that's just too long. It should be possible to > >>>> have > >>>> them run much faster by re-using the GWT environment, but last time we > >>>> tried > >>>> something broke so we backed it out. Dave Hearnden also has some good > >>>> ideas > >>>> about annotating and separating our tests into different classes based on > >>>> speed and size. > > >>>> Let's figure it out. I'd welcome some help from anyone with some GWT > >>>> experience. Meanwhile I'm going to continue cleaning up the build files > >>>> for > >>>> maintainability. > > >>>> Alex -- You received this message because you are subscribed to the Google Groups "Wave Protocol" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/wave-protocol?hl=en.
