https://bugzilla.gnome.org/show_bug.cgi?id=744932

Owen Taylor <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309537|none                        |needs-work
             status|                            |

--- Comment #103 from Owen Taylor <[email protected]> ---
Review of attachment 309537:

Seems like code motion that simplifies.

::: src/wayland/meta-wayland-pointer.c
@@ +863,3 @@
+  wl_list_insert_list (&surface->compositor->frame_callbacks,
+                       &pending->frame_callback_list);
+  wl_list_init (&pending->frame_callback_list);

But it's really not OK to have code that modifies fields of the surface
structure scattered all over different files (probably this comment belongs
earlier in this patchset).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
wayland-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-bugs

Reply via email to