https://bugzilla.gnome.org/show_bug.cgi?id=744932
--- Comment #106 from Jonas Ådahl <[email protected]> ---
(In reply to Owen Taylor from comment #103)
> Review of attachment 309537 [details] [review]:
>
> Seems like code motion that simplifies.
>
> ::: src/wayland/meta-wayland-pointer.c
> @@ +863,3 @@
> + wl_list_insert_list (&surface->compositor->frame_callbacks,
> + &pending->frame_callback_list);
> + wl_list_init (&pending->frame_callback_list);
>
> But it's really not OK to have code that modifies fields of the surface
> structure scattered all over different files (probably this comment belongs
> earlier in this patchset).
This is not modifying the surface structure but the MetaWaylandPendingState.
This is in a role-commit function, which purpose is to take what is in the
pending state and apply it, so I think it needs to modify it in order to do
that. Could use a helper though.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
wayland-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-bugs
