https://bugzilla.gnome.org/show_bug.cgi?id=786693
Bastien Nocera <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #369162|none |reviewed
status| |
--- Comment #14 from Bastien Nocera <[email protected]> ---
Review of attachment 369162:
Just some nits. You don't need to upload a new version, I'd wait until a GTK+
developer can review and merge this now.
::: gdk/wayland/gdkscreen-wayland.c
@@ +99,3 @@
GdkWaylandScreen *screen_wayland = GDK_WAYLAND_SCREEN (object);
+ if (screen_wayland->dbus_proxy && screen_wayland->dbus_setting_change_id)
Linefeed after &&
Add > 0 to change_id conditional.
@@ +947,3 @@
+ g_warning ("Could not handle fontconfig init: timestamp out of
bound");
+
+ g_variant_unref (value);
You need to call those outside the if block, otherwise you'll be leaking the
value if it doesn't match the expected type.
@@ +959,3 @@
+ screen_wayland->dbus_settings.modules = g_variant_dup_string (value,
NULL);
+
+ g_variant_unref (value);
Same thing here.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
wayland-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs
