On 01/09/16 04:13 AM, Pekka Paalanen wrote: > On Wed, 31 Aug 2016 23:17:09 +0100 > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> On 31 August 2016 at 19:10, Derek Foreman <der...@osg.samsung.com> wrote: >>> Thanks for taking a look! >>> >>> On 31/08/16 04:22 AM, Emil Velikov wrote: >>>> On 30 August 2016 at 19:56, Derek Foreman <der...@osg.samsung.com> wrote: >>>>> From: "Reynaldo H. Verdejo Pinochet" <reyna...@osg.samsung.com> >>>>> <snip snip snip> >>>> As mentioned before using --prefix=$WLD/foo + make install will make >>>> things shorter/simpler >>> >>> Takes more time (waiting for misc relinking during the install - perhaps >>> not overly onerous for wayland/weston/libinput), takes more steps >>> (performing the install), takes more effort to undo (make distclean is >>> essentially a complete uninstall of a package - of course I could have a >>> separate prefix for each repo and a bunch more env vars, so perhaps >>> that's not an important distinction), takes more space on disk. > > Even with that explanation which doesn't seem too compelling to me, I'm > not sure why anyone would like to run uninstalled apart from some > Android hackery, but wayland-build-tools is Bryce's domain so he can > decide what goes in there.
Indeed. As is made obvious by our email addresses, Bryce, Reynaldo and I all work for the same company. So I like to avoid putting pressure on Bryce to even review my work, to avoid any appearance of conflict of interest. But yes, ultimately Bryce's decision (I'd hoped to see an Ack or two from "outsiders" that saw this as at least somewhat useful though.) We're fine using this script privately if nobody else wants it - the intent was to share it, not promote or force an undesirable workflow on others. > I would have hoped the commit message to explain "why it is useful", > not just "you can now do this". Ok, we'll provide a better commit log with the next revision. > This also applies to the -uninstalled.pc files. I may have once used > them in my dark Android past, but I have happily forgot why they ever > existed. Patches adding them would be nice to remind us all what they > are needed for. Oh dear. I've been avoiding mention of that, as it takes me to a dark place, and I'm not sure that particular usage is relevant. :) We'll provide a v2 of the weston patches with a brief explanation of what -uninstalled.pc file do. It hadn't occurred to me that they were such an obscure concept, sorry. I assume the wayland patches (which are just bug fixes to the existing files) don't need new commit logs? Thanks, Derek
signature.asc
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel