On Fri, Oct 07, 2016 at 02:48:41PM +0300, Ran Benita wrote:
> > + /* Look up the appropriate locale, or use "C" as default */
> > + locale = getenv("LC_ALL");
> > + if (!locale)
> > + locale = "C";
>
> Is there a reason why you decided not to use the "full" procedure, i.e.
> also try LC_CTYPE and LANG?
No particular reason. I did wonder if it would be worthwhile to check
those too, but wasn't sure what order they should be checked. Should it
be LANG first, then LC_CTYPE, and then fallback to LC_ALL?
> > + /* Set up XKB compose table */
> > + compose_table =
> > xkb_compose_table_new_from_locale(input->display->xkb_context,
> > + locale,
> > +
> > XKB_COMPOSE_COMPILE_NO_FLAGS);
> > + if (!compose_table) {
> > + fprintf(stderr, "could not create XKB compose table for locale
> > '%s'\n", locale);
> > + xkb_state_unref(state);
> > + xkb_keymap_unref(keymap);
> > + return;
> > + }
>
> In my opinion, it would be better to proceed without compose, than to
> fail the entire setup. If, for example, the compose files are not
> available, then it's OK to just skip it. The alternative is that the
> window does not show up at all (I assume).
>
> Ran
Ok, good point.
Bryce
_______________________________________________
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
