On May 7, 2010, at 4:39 PM, mdipierro wrote:

> Done. I added one test each. we should have more tests in gluon/tests
> we have none, only doctests for validators.

Yes, we should (though doctests are nice documentation for validators).

There's a plugin for nose that will run doctests along with unit tests.

> 
> On May 7, 4:26 pm, Jonathan Lundell <jlund...@pobox.com> wrote:
>> On May 7, 2010, at 9:30 AM, Iceberg wrote:
>> 
>>> Right now, IS_DATE_IN_RANGE(minimum=foo, maximum=bar) does NOT accept
>>> the given minimum nor maximum value. That is not the design intention
>>> according to error message. Please get rid off the two equal marks in
>>> IS_DATE_IN_RANGE.__call__().
>> 
>>> Same applies to IS_DATETIME_IN_RANGE.
>> 
>> Anybody who patches this: please add the relevant doctests.


Reply via email to