Title: [87536] trunk/Source/_javascript_Core
Revision
87536
Author
oli...@apple.com
Date
2011-05-27 12:48:25 -0700 (Fri, 27 May 2011)

Log Message

2011-05-27  Oliver Hunt  <oli...@apple.com>

        Reviewed by Geoffrey Garen.

        Add a few validity assertions to JSCallbackObject
        https://bugs.webkit.org/show_bug.cgi?id=61659

        * API/JSCallbackObject.h:
        (JSC::JSCallbackObject::visitChildren):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/API/JSCallbackObject.h (87535 => 87536)


--- trunk/Source/_javascript_Core/API/JSCallbackObject.h	2011-05-27 19:44:09 UTC (rev 87535)
+++ trunk/Source/_javascript_Core/API/JSCallbackObject.h	2011-05-27 19:48:25 UTC (rev 87536)
@@ -174,6 +174,9 @@
 
     virtual void visitChildren(SlotVisitor& visitor)
     {
+        ASSERT_GC_OBJECT_INHERITS((static_cast<Base*>(this)), &JSCallbackObject<Base>::s_info);
+        COMPILE_ASSERT(StructureFlags & OverridesVisitChildren, OverridesVisitChildrenWithoutSettingFlag);
+        ASSERT(Base::structure()->typeInfo().overridesVisitChildren());
         Base::visitChildren(visitor);
         m_callbackObjectData->visitChildren(visitor);
     }

Modified: trunk/Source/_javascript_Core/ChangeLog (87535 => 87536)


--- trunk/Source/_javascript_Core/ChangeLog	2011-05-27 19:44:09 UTC (rev 87535)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-05-27 19:48:25 UTC (rev 87536)
@@ -1,5 +1,15 @@
 2011-05-27  Oliver Hunt  <oli...@apple.com>
 
+        Reviewed by Geoffrey Garen.
+
+        Add a few validity assertions to JSCallbackObject
+        https://bugs.webkit.org/show_bug.cgi?id=61659
+
+        * API/JSCallbackObject.h:
+        (JSC::JSCallbackObject::visitChildren):
+
+2011-05-27  Oliver Hunt  <oli...@apple.com>
+
         Build fix
 
         * runtime/RegExpCache.cpp:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to