Title: [87537] trunk/Tools
- Revision
- 87537
- Author
- aro...@apple.com
- Date
- 2011-05-27 12:50:35 -0700 (Fri, 27 May 2011)
Log Message
Always decode tester names from location.hash
When navigating directly to a tester-specific URL (e.g.,
<http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
with a URL-encoded tester name in the page, and then the encoded name could make its way
into Bugzilla bugs. Bad!
Reviewed by David Kilzer.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
decodeURIComponent before trying to use it.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js (87536 => 87537)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-05-27 19:48:25 UTC (rev 87536)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-05-27 19:50:35 UTC (rev 87537)
@@ -39,7 +39,7 @@
parseHash: function(hash) {
var match = /#\/(.*)/.exec(hash);
if (match)
- this._displayBuilder(this._buildbot.builderNamed(match[1]));
+ this._displayBuilder(this._buildbot.builderNamed(decodeURIComponent(match[1])));
else
this._displayTesters();
},
Modified: trunk/Tools/ChangeLog (87536 => 87537)
--- trunk/Tools/ChangeLog 2011-05-27 19:48:25 UTC (rev 87536)
+++ trunk/Tools/ChangeLog 2011-05-27 19:50:35 UTC (rev 87537)
@@ -1,5 +1,20 @@
2011-05-27 Adam Roben <aro...@apple.com>
+ Always decode tester names from location.hash
+
+ When navigating directly to a tester-specific URL (e.g.,
+ <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
+ with a URL-encoded tester name in the page, and then the encoded name could make its way
+ into Bugzilla bugs. Bad!
+
+ Reviewed by David Kilzer.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
+ (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
+ decodeURIComponent before trying to use it.
+
+2011-05-27 Adam Roben <aro...@apple.com>
+
Remove testing code that snuck into r87528
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
