Title: [88105] trunk/Source/WebKit/chromium
- Revision
- 88105
- Author
- [email protected]
- Date
- 2011-06-04 03:42:18 -0700 (Sat, 04 Jun 2011)
Log Message
2011-06-04 Nico Weber <[email protected]>
Reviewed by James Robinson.
[chromium] Make WebFrameImpl destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62065
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
* src/WebFrameImpl.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (88104 => 88105)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-06-04 10:32:26 UTC (rev 88104)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-04 10:42:18 UTC (rev 88105)
@@ -1,3 +1,17 @@
+2011-06-04 Nico Weber <[email protected]>
+
+ Reviewed by James Robinson.
+
+ [chromium] Make WebFrameImpl destructor virtual
+ https://bugs.webkit.org/show_bug.cgi?id=62065
+
+ This is _not_ to fix a real bug, just to make clang's
+ -Wdelete-non-virtual-dtor happy. As discussed at
+ http://codereview.chromium.org/7094005/, we prefer making leaf class
+ destructors virtual over making the leaf classes final.
+
+ * src/WebFrameImpl.h:
+
2011-06-03 Philippe Beauchamp <[email protected]>
Reviewed by Dimitri Glazkov.
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.h (88104 => 88105)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.h 2011-06-04 10:32:26 UTC (rev 88104)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.h 2011-06-04 10:42:18 UTC (rev 88105)
@@ -212,7 +212,7 @@
virtual WebString layerTreeAsText(bool showDebugInfo = false) const;
static PassRefPtr<WebFrameImpl> create(WebFrameClient* client);
- ~WebFrameImpl();
+ virtual ~WebFrameImpl();
// Called by the WebViewImpl to initialize its main frame:
void initializeAsMainFrame(WebViewImpl*);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
