Title: [88106] trunk/Source/WebKit/chromium
- Revision
- 88106
- Author
- [email protected]
- Date
- 2011-06-04 03:50:51 -0700 (Sat, 04 Jun 2011)
Log Message
2011-06-04 Nico Weber <[email protected]>
Reviewed by James Robinson.
[chromium] Give VoidCallbackClient a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=62067
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
* src/NotificationPresenterImpl.cpp:
(WebKit::VoidCallbackClient::~VoidCallbackClient):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (88105 => 88106)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-06-04 10:42:18 UTC (rev 88105)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-04 10:50:51 UTC (rev 88106)
@@ -2,6 +2,21 @@
Reviewed by James Robinson.
+ [chromium] Give VoidCallbackClient a virtual destructor
+ https://bugs.webkit.org/show_bug.cgi?id=62067
+
+ This is _not_ to fix a real bug, just to make clang's
+ -Wdelete-non-virtual-dtor happy. As discussed at
+ http://codereview.chromium.org/7094005/, we prefer making leaf class
+ destructors virtual over making the leaf classes final.
+
+ * src/NotificationPresenterImpl.cpp:
+ (WebKit::VoidCallbackClient::~VoidCallbackClient):
+
+2011-06-04 Nico Weber <[email protected]>
+
+ Reviewed by James Robinson.
+
[chromium] Make WebFrameImpl destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62065
Modified: trunk/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp (88105 => 88106)
--- trunk/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp 2011-06-04 10:42:18 UTC (rev 88105)
+++ trunk/Source/WebKit/chromium/src/NotificationPresenterImpl.cpp 2011-06-04 10:50:51 UTC (rev 88106)
@@ -56,6 +56,8 @@
{
}
+ virtual ~VoidCallbackClient() { }
+
virtual void permissionRequestComplete()
{
if (m_callback)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
