Title: [88109] trunk/Source/WebKit/chromium
- Revision
- 88109
- Author
- [email protected]
- Date
- 2011-06-04 04:14:49 -0700 (Sat, 04 Jun 2011)
Log Message
2011-06-04 Nico Weber <[email protected]>
Reviewed by James Robinson.
[chromium] Make ChromePrintContext's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62076
Since WebFrameImpl's m_printContext is a OnwPtr<ChromePrintContext>
that is dynamically set to either a ChromePrintContext or a
ChromePluginPrintContext, this fixes an actual bug.
* src/WebFrameImpl.cpp:
(WebKit::ChromePrintContext::~ChromePrintContext):
(WebKit::ChromePluginPrintContext::~ChromePluginPrintContext):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (88108 => 88109)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-06-04 11:06:49 UTC (rev 88108)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-04 11:14:49 UTC (rev 88109)
@@ -2,6 +2,21 @@
Reviewed by James Robinson.
+ [chromium] Make ChromePrintContext's destructor virtual
+ https://bugs.webkit.org/show_bug.cgi?id=62076
+
+ Since WebFrameImpl's m_printContext is a OnwPtr<ChromePrintContext>
+ that is dynamically set to either a ChromePrintContext or a
+ ChromePluginPrintContext, this fixes an actual bug.
+
+ * src/WebFrameImpl.cpp:
+ (WebKit::ChromePrintContext::~ChromePrintContext):
+ (WebKit::ChromePluginPrintContext::~ChromePluginPrintContext):
+
+2011-06-04 Nico Weber <[email protected]>
+
+ Reviewed by James Robinson.
+
[chromium] Make WebTextCheckingCompletionImpl's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62074
Modified: trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp (88108 => 88109)
--- trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2011-06-04 11:06:49 UTC (rev 88108)
+++ trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp 2011-06-04 11:14:49 UTC (rev 88109)
@@ -306,6 +306,8 @@
{
}
+ virtual ~ChromePrintContext() { }
+
virtual void begin(float width, float height)
{
ASSERT(!m_printedPageWidth);
@@ -376,6 +378,8 @@
{
}
+ virtual ~ChromePluginPrintContext() { }
+
virtual void begin(float width, float height)
{
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
