Title: [88108] trunk/Source/WebKit/chromium
- Revision
- 88108
- Author
- [email protected]
- Date
- 2011-06-04 04:06:49 -0700 (Sat, 04 Jun 2011)
Log Message
2011-06-04 Nico Weber <[email protected]>
Reviewed by James Robinson.
[chromium] Make WebTextCheckingCompletionImpl's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62074
This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.
* src/WebTextCheckingCompletionImpl.h:
(WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (88107 => 88108)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-06-04 10:58:47 UTC (rev 88107)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-04 11:06:49 UTC (rev 88108)
@@ -2,6 +2,21 @@
Reviewed by James Robinson.
+ [chromium] Make WebTextCheckingCompletionImpl's destructor virtual
+ https://bugs.webkit.org/show_bug.cgi?id=62074
+
+ This is _not_ to fix a real bug, just to make clang's
+ -Wdelete-non-virtual-dtor happy. As discussed at
+ http://codereview.chromium.org/7094005/, we prefer making leaf class
+ destructors virtual over making the leaf classes final.
+
+ * src/WebTextCheckingCompletionImpl.h:
+ (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
+
+2011-06-04 Nico Weber <[email protected]>
+
+ Reviewed by James Robinson.
+
[chromium] Make PlatformMessagePortChannel's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62072
Modified: trunk/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.h (88107 => 88108)
--- trunk/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.h 2011-06-04 10:58:47 UTC (rev 88107)
+++ trunk/Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.h 2011-06-04 11:06:49 UTC (rev 88108)
@@ -46,6 +46,8 @@
{
}
+ virtual ~WebTextCheckingCompletionImpl() { }
+
virtual void didFinishCheckingText(const WebVector<WebTextCheckingResult>&);
private:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
