Title: [88639] trunk/Source/WebKit/efl
Revision
88639
Author
[email protected]
Date
2011-06-13 08:09:59 -0700 (Mon, 13 Jun 2011)

Log Message

2011-06-13  KwangHyuk Kim  <[email protected]>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 color space
        https://bugs.webkit.org/show_bug.cgi?id=62448

        Use CAIRO_FORMAT_ARGB32 for EWK as pixman does not support the fast path for converting
        from ARGB32 to AGB24 when using source over operation in combination with a bilinear filter

        * ewk/ewk_tiled_model.c:
        (ewk_tile_new):
        * ewk/ewk_view_single.c:
        (_ewk_view_single_smart_repaints_process):

Modified Paths

Property Changed

Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (88638 => 88639)


--- trunk/Source/WebKit/efl/ChangeLog	2011-06-13 14:58:05 UTC (rev 88638)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-06-13 15:09:59 UTC (rev 88639)
@@ -1,3 +1,18 @@
+2011-06-13  KwangHyuk Kim  <[email protected]>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 color space
+        https://bugs.webkit.org/show_bug.cgi?id=62448 
+ 
+        Use CAIRO_FORMAT_ARGB32 for EWK as pixman does not support the fast path for converting
+        from ARGB32 to AGB24 when using source over operation in combination with a bilinear filter
+
+        * ewk/ewk_tiled_model.c:
+        (ewk_tile_new):
+        * ewk/ewk_view_single.c:
+        (_ewk_view_single_smart_repaints_process):
+
 2011-06-12  Adam Barth  <[email protected]>
 
         Reviewed by Alexey Proskuryakov.

Modified: trunk/Source/WebKit/efl/ewk/ewk_tiled_model.c (88638 => 88639)


--- trunk/Source/WebKit/efl/ewk/ewk_tiled_model.c	2011-06-13 14:58:05 UTC (rev 88638)
+++ trunk/Source/WebKit/efl/ewk/ewk_tiled_model.c	2011-06-13 15:09:59 UTC (rev 88639)
@@ -260,7 +260,7 @@
     if (cspace == EVAS_COLORSPACE_ARGB8888) {
         bytes = area * 4;
         stride = w * 4;
-        format = CAIRO_FORMAT_RGB24;
+        format = CAIRO_FORMAT_ARGB32;
     } else if (cspace == EVAS_COLORSPACE_RGB565_A5P) {
         bytes = area * 2;
         stride = w * 2;

Modified: trunk/Source/WebKit/efl/ewk/ewk_view_single.c (88638 => 88639)


--- trunk/Source/WebKit/efl/ewk/ewk_view_single.c	2011-06-13 14:58:05 UTC (rev 88638)
+++ trunk/Source/WebKit/efl/ewk/ewk_view_single.c	2011-06-13 15:09:59 UTC (rev 88639)
@@ -391,12 +391,8 @@
 
     pixels = evas_object_image_data_get(sd->backing_store, 1);
     evas_object_image_size_get(sd->backing_store, &ow, &oh);
+    format = CAIRO_FORMAT_ARGB32;
 
-    if (sd->bg_color.a < 255)
-        format = CAIRO_FORMAT_ARGB32;
-    else
-        format = CAIRO_FORMAT_RGB24;
-
     surface = cairo_image_surface_create_for_data
         ((unsigned char*)pixels, format, ow, oh, ow * 4);
     status = cairo_surface_status(surface);
Property changes on: trunk/Source/WebKit/efl/ewk/ewk_view_single.c
___________________________________________________________________

Added: svn:executable

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to