Modified: trunk/Source/WebKit2/ChangeLog (88639 => 88640)
--- trunk/Source/WebKit2/ChangeLog 2011-06-13 15:09:59 UTC (rev 88639)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-13 15:28:56 UTC (rev 88640)
@@ -2,6 +2,25 @@
Reviewed by Kenneth Rohde Christiansen.
+ [EFL][WK2] Minor fix: fix coding style and remove unnecessary codes for WebKit2 efl port's PageClientImpl
+ https://bugs.webkit.org/show_bug.cgi?id=62429
+
+ * UIProcess/API/efl/PageClientImpl.cpp:
+ (WebKit::PageClientImpl::scrollView):
+ (WebKit::PageClientImpl::setCursor):
+ (WebKit::PageClientImpl::windowToScreen):
+ (WebKit::PageClientImpl::doneWithKeyEvent):
+ (WebKit::PageClientImpl::setFindIndicator):
+ (WebKit::PageClientImpl::didCommitLoadForMainFrame):
+ (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
+ (WebKit::PageClientImpl::findStringInCustomRepresentation):
+ (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
+ * UIProcess/API/efl/PageClientImpl.h:
+
+2011-06-13 Eunmi Lee <[email protected]>
+
+ Reviewed by Kenneth Rohde Christiansen.
+
[EFL][WK2] Add initial WebPreferencesEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62525
Modified: trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp (88639 => 88640)
--- trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp 2011-06-13 15:09:59 UTC (rev 88639)
+++ trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp 2011-06-13 15:28:56 UTC (rev 88640)
@@ -64,13 +64,9 @@
notImplemented();
}
-void PageClientImpl::scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset)
+void PageClientImpl::scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize&)
{
setViewNeedsDisplay(scrollRect);
-#define USE_EWK_TOUCH 1
-#if USE_EWK_TOUCH
- evas_object_move(m_viewObject, 0, 0);
-#endif
}
WebCore::IntSize PageClientImpl::viewSize()
@@ -124,7 +120,7 @@
notImplemented();
}
-void PageClientImpl::setCursor(const Cursor& cursor)
+void PageClientImpl::setCursor(const Cursor&)
{
notImplemented();
}
@@ -167,13 +163,13 @@
return viewRect;
}
-IntRect PageClientImpl::windowToScreen(const IntRect& rect)
+IntRect PageClientImpl::windowToScreen(const IntRect&)
{
notImplemented();
return IntRect();
}
-void PageClientImpl::doneWithKeyEvent(const NativeWebKeyboardEvent&, bool wasEventHandled)
+void PageClientImpl::doneWithKeyEvent(const NativeWebKeyboardEvent&, bool)
{
notImplemented();
}
@@ -190,7 +186,7 @@
return 0;
}
-void PageClientImpl::setFindIndicator(PassRefPtr<FindIndicator>, bool fadeOut)
+void PageClientImpl::setFindIndicator(PassRefPtr<FindIndicator>, bool)
{
notImplemented();
}
@@ -200,12 +196,12 @@
notImplemented();
}
-void PageClientImpl::didCommitLoadForMainFrame(bool useCustomRepresentation)
+void PageClientImpl::didCommitLoadForMainFrame(bool)
{
notImplemented();
}
-void PageClientImpl::didFinishLoadingDataForCustomRepresentation(const String& suggestedFilename, const CoreIPC::DataReference&)
+void PageClientImpl::didFinishLoadingDataForCustomRepresentation(const String&, const CoreIPC::DataReference&)
{
notImplemented();
}
@@ -226,12 +222,12 @@
notImplemented();
}
-void PageClientImpl::findStringInCustomRepresentation(const String&, FindOptions, unsigned maxMatchCount)
+void PageClientImpl::findStringInCustomRepresentation(const String&, FindOptions, unsigned)
{
notImplemented();
}
-void PageClientImpl::countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned maxMatchCount)
+void PageClientImpl::countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned)
{
notImplemented();
}
Modified: trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.h (88639 => 88640)
--- trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.h 2011-06-13 15:09:59 UTC (rev 88639)
+++ trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.h 2011-06-13 15:28:56 UTC (rev 88640)
@@ -50,7 +50,7 @@
virtual PassOwnPtr<DrawingAreaProxy> createDrawingAreaProxy();
virtual void setViewNeedsDisplay(const WebCore::IntRect&);
virtual void displayView();
- virtual void scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset);
+ virtual void scrollView(const WebCore::IntRect&, const WebCore::IntSize&);
virtual WebCore::IntSize viewSize();
virtual bool isViewWindowActive();
virtual bool isViewFocused();
@@ -74,23 +74,23 @@
virtual WebCore::FloatRect convertToUserSpace(const WebCore::FloatRect&);
virtual WebCore::IntRect windowToScreen(const WebCore::IntRect&);
- virtual void doneWithKeyEvent(const NativeWebKeyboardEvent&, bool wasEventHandled);
+ virtual void doneWithKeyEvent(const NativeWebKeyboardEvent&, bool);
virtual PassRefPtr<WebPopupMenuProxy> createPopupMenuProxy(WebPageProxy*);
virtual PassRefPtr<WebContextMenuProxy> createContextMenuProxy(WebPageProxy*);
- virtual void setFindIndicator(PassRefPtr<FindIndicator>, bool fadeOut);
+ virtual void setFindIndicator(PassRefPtr<FindIndicator>, bool);
virtual void didChangeScrollbarsForMainFrame() const;
- virtual void didCommitLoadForMainFrame(bool useCustomRepresentation);
- virtual void didFinishLoadingDataForCustomRepresentation(const String& suggestedFilename, const CoreIPC::DataReference&);
+ virtual void didCommitLoadForMainFrame(bool);
+ virtual void didFinishLoadingDataForCustomRepresentation(const String&, const CoreIPC::DataReference&);
virtual double customRepresentationZoomFactor();
virtual void setCustomRepresentationZoomFactor(double);
- virtual void flashBackingStoreUpdates(const Vector<WebCore::IntRect>& updateRects);
- virtual void findStringInCustomRepresentation(const String&, FindOptions, unsigned maxMatchCount);
- virtual void countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned maxMatchCount);
+ virtual void flashBackingStoreUpdates(const Vector<WebCore::IntRect>&);
+ virtual void findStringInCustomRepresentation(const String&, FindOptions, unsigned);
+ virtual void countStringMatchesInCustomRepresentation(const String&, FindOptions, unsigned);
virtual float userSpaceScaleFactor() const;
