Title: [88983] trunk/Source/WebKit2
- Revision
- 88983
- Author
- [email protected]
- Date
- 2011-06-15 16:17:29 -0700 (Wed, 15 Jun 2011)
Log Message
WKSecurityOriginGetProtocol and WKSecurityOriginGetHost are named wrong because they return copied strings
<https://bugs.webkit.org/show_bug.cgi?id=62763>
<rdar://problem/9618071>
Reviewed by Sam Weinig.
* Shared/API/c/WKSecurityOrigin.cpp:
(WKSecurityOriginCopyProtocol):
Renamed to use "Copy" instead of "Get" because it returns a copy.
(WKSecurityOriginCopyHost):
Ditto.
* Shared/API/c/WKSecurityOrigin.h:
Updated declarations.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (88982 => 88983)
--- trunk/Source/WebKit2/ChangeLog 2011-06-15 23:13:23 UTC (rev 88982)
+++ trunk/Source/WebKit2/ChangeLog 2011-06-15 23:17:29 UTC (rev 88983)
@@ -1,3 +1,20 @@
+2011-06-15 John Sullivan <[email protected]>
+
+ Reviewed by Sam Weinig.
+
+ WKSecurityOriginGetProtocol and WKSecurityOriginGetHost are named wrong because they return copied strings
+ <https://bugs.webkit.org/show_bug.cgi?id=62763>
+ <rdar://problem/9618071>
+
+ * Shared/API/c/WKSecurityOrigin.cpp:
+ (WKSecurityOriginCopyProtocol):
+ Renamed to use "Copy" instead of "Get" because it returns a copy.
+ (WKSecurityOriginCopyHost):
+ Ditto.
+
+ * Shared/API/c/WKSecurityOrigin.h:
+ Updated declarations.
+
2011-06-14 Jon Honeycutt <[email protected]>
REGRESSION(78201): Windowless Flash plug-ins are transparent on some sites
Modified: trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.cpp (88982 => 88983)
--- trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.cpp 2011-06-15 23:13:23 UTC (rev 88982)
+++ trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.cpp 2011-06-15 23:17:29 UTC (rev 88983)
@@ -48,12 +48,12 @@
return toAPI(securityOrigin.release().leakRef());
}
-WKStringRef WKSecurityOriginGetProtocol(WKSecurityOriginRef securityOrigin)
+WKStringRef WKSecurityOriginCopyProtocol(WKSecurityOriginRef securityOrigin)
{
return toCopiedAPI(toImpl(securityOrigin)->protocol());
}
-WKStringRef WKSecurityOriginGetHost(WKSecurityOriginRef securityOrigin)
+WKStringRef WKSecurityOriginCopyHost(WKSecurityOriginRef securityOrigin)
{
return toCopiedAPI(toImpl(securityOrigin)->host());
}
Modified: trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.h (88982 => 88983)
--- trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.h 2011-06-15 23:13:23 UTC (rev 88982)
+++ trunk/Source/WebKit2/Shared/API/c/WKSecurityOrigin.h 2011-06-15 23:17:29 UTC (rev 88983)
@@ -37,8 +37,8 @@
WK_EXPORT WKSecurityOriginRef WKSecurityOriginCreateFromIdentifier(WKStringRef identifier);
WK_EXPORT WKSecurityOriginRef WKSecurityOriginCreate(WKStringRef protocol, WKStringRef host, int port);
-WK_EXPORT WKStringRef WKSecurityOriginGetProtocol(WKSecurityOriginRef securityOrigin);
-WK_EXPORT WKStringRef WKSecurityOriginGetHost(WKSecurityOriginRef securityOrigin);
+WK_EXPORT WKStringRef WKSecurityOriginCopyProtocol(WKSecurityOriginRef securityOrigin);
+WK_EXPORT WKStringRef WKSecurityOriginCopyHost(WKSecurityOriginRef securityOrigin);
WK_EXPORT unsigned short WKSecurityOriginGetPort(WKSecurityOriginRef securityOrigin);
#ifdef __cplusplus
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
