Title: [88984] trunk/Source/WebCore
- Revision
- 88984
- Author
- [email protected]
- Date
- 2011-06-15 17:12:12 -0700 (Wed, 15 Jun 2011)
Log Message
2011-06-15 Sam Weinig <[email protected]>
Reviewed by Alexey Proskuryakov.
Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache
https://bugs.webkit.org/show_bug.cgi?id=62764
This is an non-reproducible high volume crash, so no test :(.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::detachFromFrame):
Be conservative and stop loading when we detach a document loader from a frame.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88983 => 88984)
--- trunk/Source/WebCore/ChangeLog 2011-06-15 23:17:29 UTC (rev 88983)
+++ trunk/Source/WebCore/ChangeLog 2011-06-16 00:12:12 UTC (rev 88984)
@@ -1,3 +1,16 @@
+2011-06-15 Sam Weinig <[email protected]>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Frequent crashes due to null frame below ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache
+ https://bugs.webkit.org/show_bug.cgi?id=62764
+
+ This is an non-reproducible high volume crash, so no test :(.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::detachFromFrame):
+ Be conservative and stop loading when we detach a document loader from a frame.
+
2011-06-15 Beth Dakin <[email protected]>
Reviewed by Simon Fraser.
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (88983 => 88984)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2011-06-15 23:17:29 UTC (rev 88983)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2011-06-16 00:12:12 UTC (rev 88984)
@@ -399,6 +399,11 @@
void DocumentLoader::detachFromFrame()
{
ASSERT(m_frame);
+
+ // It never makes sense to have a document loader that is detached from its
+ // frame have any loads active, so go ahead and kill all the loads.
+ stopLoading();
+
#if ENABLE(OFFLINE_WEB_APPLICATIONS)
m_applicationCacheHost->setDOMApplicationCache(0);
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
