Title: [89318] trunk/Source/WebCore
- Revision
- 89318
- Author
- [email protected]
- Date
- 2011-06-20 17:04:23 -0700 (Mon, 20 Jun 2011)
Log Message
2011-06-20 Antonio Gomes <[email protected]>
Reviewed by Ryosuke Niwa.
Stop adding empty rects in FrameSelection::getClippedVisibleTextRectangles
https://bugs.webkit.org/show_bug.cgi?id=63018
No new tests needed, since it causes no behavioral change.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::getClippedVisibleTextRectangles):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (89317 => 89318)
--- trunk/Source/WebCore/ChangeLog 2011-06-21 00:01:18 UTC (rev 89317)
+++ trunk/Source/WebCore/ChangeLog 2011-06-21 00:04:23 UTC (rev 89318)
@@ -1,3 +1,15 @@
+2011-06-20 Antonio Gomes <[email protected]>
+
+ Reviewed by Ryosuke Niwa.
+
+ Stop adding empty rects in FrameSelection::getClippedVisibleTextRectangles
+ https://bugs.webkit.org/show_bug.cgi?id=63018
+
+ No new tests needed, since it causes no behavioral change.
+
+ * editing/FrameSelection.cpp:
+ (WebCore::FrameSelection::getClippedVisibleTextRectangles):
+
2011-06-20 Joseph Pecoraro <[email protected]>
Reviewed by Pavel Feldman.
Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (89317 => 89318)
--- trunk/Source/WebCore/editing/FrameSelection.cpp 2011-06-21 00:01:18 UTC (rev 89317)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2011-06-21 00:04:23 UTC (rev 89318)
@@ -1788,11 +1788,12 @@
Vector<FloatQuad> quads;
toNormalizedRange()->textQuads(quads, true);
- // FIXME: We are appending empty rectangles to the list for those that fall outside visibleContentRect.
- // It might be better to omit those rectangles entirely.
size_t size = quads.size();
- for (size_t i = 0; i < size; ++i)
- rectangles.append(intersection(quads[i].enclosingBoundingBox(), visibleContentRect));
+ for (size_t i = 0; i < size; ++i) {
+ FloatRect intersectionRect = intersection(quads[i].enclosingBoundingBox(), visibleContentRect);
+ if (!intersectionRect.isEmpty())
+ rectangles.append(intersectionRect);
+ }
}
// Scans logically forward from "start", including any child frames.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
