Title: [89319] trunk/Source/WebCore
- Revision
- 89319
- Author
- [email protected]
- Date
- 2011-06-20 17:34:12 -0700 (Mon, 20 Jun 2011)
Log Message
2011-06-20 Martin Robinson <[email protected]>
Reviewed by Xan Lopez.
[GTK] Windowless plugins sometimes crash with a BadMatch error
https://bugs.webkit.org/show_bug.cgi?id=63020
Do not try to create an XPixmap with any of the dimensions as zero.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePluginWidget): Guard against and empty window rect
before trying to create a windowless plugin pixmap.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (89318 => 89319)
--- trunk/Source/WebCore/ChangeLog 2011-06-21 00:04:23 UTC (rev 89318)
+++ trunk/Source/WebCore/ChangeLog 2011-06-21 00:34:12 UTC (rev 89319)
@@ -1,3 +1,16 @@
+2011-06-20 Martin Robinson <[email protected]>
+
+ Reviewed by Xan Lopez.
+
+ [GTK] Windowless plugins sometimes crash with a BadMatch error
+ https://bugs.webkit.org/show_bug.cgi?id=63020
+
+ Do not try to create an XPixmap with any of the dimensions as zero.
+
+ * plugins/gtk/PluginViewGtk.cpp:
+ (WebCore::PluginView::updatePluginWidget): Guard against and empty window rect
+ before trying to create a windowless plugin pixmap.
+
2011-06-20 Antonio Gomes <[email protected]>
Reviewed by Ryosuke Niwa.
Modified: trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp (89318 => 89319)
--- trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp 2011-06-21 00:04:23 UTC (rev 89318)
+++ trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp 2011-06-21 00:34:12 UTC (rev 89319)
@@ -145,7 +145,7 @@
return;
#if defined(XP_UNIX)
- if (!m_isWindowed) {
+ if (!m_isWindowed && !m_windowRect.isEmpty()) {
Display* display = GDK_DISPLAY_XDISPLAY(gdk_display_get_default());
if (m_drawable)
XFreePixmap(display, m_drawable);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
