Title: [89474] trunk
- Revision
- 89474
- Author
- [email protected]
- Date
- 2011-06-22 13:39:01 -0700 (Wed, 22 Jun 2011)
Log Message
2011-06-22 Matthew Delaney <[email protected]>
Reviewed by Oliver Hunt.
Canvas in layer obscures overlapping span
https://bugs.webkit.org/show_bug.cgi?id=63161
Test: compositing/layer-creation/spanOverlapsCanvas.html
* rendering/RenderLayer.cpp: Added checks for canvas to be layered properly.
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::isSelfPaintingLayer):
2011-06-22 Matthew Delaney <[email protected]>
Reviewed by Oliver Hunt.
Canvas in layer obscures overlapping span
https://bugs.webkit.org/show_bug.cgi?id=63161
* compositing/layer-creation/spanOverlapsCanvas.html: Added.
* platform/mac/compositing/layer-creation: Added.
* platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
* platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (89473 => 89474)
--- trunk/LayoutTests/ChangeLog 2011-06-22 20:35:27 UTC (rev 89473)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 20:39:01 UTC (rev 89474)
@@ -1,3 +1,15 @@
+2011-06-22 Matthew Delaney <[email protected]>
+
+ Reviewed by Oliver Hunt.
+
+ Canvas in layer obscures overlapping span
+ https://bugs.webkit.org/show_bug.cgi?id=63161
+
+ * compositing/layer-creation/spanOverlapsCanvas.html: Added.
+ * platform/mac/compositing/layer-creation: Added.
+ * platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
+ * platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.
+
2011-06-22 Jessie Berlin <[email protected]>
REGRESSION (r89426-r89428): inspector/console/console-trace-in-eval.html failing on
Added: trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html (0 => 89474)
--- trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html (rev 0)
+++ trunk/LayoutTests/compositing/layer-creation/spanOverlapsCanvas.html 2011-06-22 20:39:01 UTC (rev 89474)
@@ -0,0 +1,30 @@
+<!DOCTYPE html>
+<html xmlns="http://www.w3.org/1999/xhtml">
+<head>
+ <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
+ <meta name="viewport" content="width=480"/>
+
+ <script>
+ window.layoutTestController && window.layoutTestController.layerTreeAsText();
+
+ function init() {
+ var ctx = document.getElementById("world").getContext("2d");
+ ctx.fillStyle = "red";
+ ctx.fillRect(0,0,ctx.canvas.width,ctx.canvas.height);
+ }
+ </script>
+
+ <style>
+ #headerbar {
+ width: 100px;
+ height: 50px;
+ background-color: green;
+ position: absolute;
+ }
+ </style>
+</head>
+<body _onLoad_="init()">
+ <div id="headerbar"></div>
+ <canvas id="world" width="100" height="50"></canvas>
+</body>
+</html>
Added: trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png
(Binary files differ)
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt (0 => 89474)
--- trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt 2011-06-22 20:39:01 UTC (rev 89474)
@@ -0,0 +1,10 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x70
+ RenderBlock {HTML} at (0,0) size 800x70
+ RenderBody {BODY} at (8,8) size 784x54
+ RenderText {#text} at (0,0) size 0x0
+layer at (8,8) size 100x50
+ RenderHTMLCanvas {CANVAS} at (0,0) size 100x50
+layer at (8,8) size 100x50
+ RenderBlock (positioned) {DIV} at (8,8) size 100x50 [bgcolor=#008000]
Modified: trunk/Source/WebCore/ChangeLog (89473 => 89474)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 20:35:27 UTC (rev 89473)
+++ trunk/Source/WebCore/ChangeLog 2011-06-22 20:39:01 UTC (rev 89474)
@@ -1,3 +1,16 @@
+2011-06-22 Matthew Delaney <[email protected]>
+
+ Reviewed by Oliver Hunt.
+
+ Canvas in layer obscures overlapping span
+ https://bugs.webkit.org/show_bug.cgi?id=63161
+
+ Test: compositing/layer-creation/spanOverlapsCanvas.html
+
+ * rendering/RenderLayer.cpp: Added checks for canvas to be layered properly.
+ (WebCore::RenderLayer::shouldBeNormalFlowOnly):
+ (WebCore::RenderLayer::isSelfPaintingLayer):
+
2011-06-22 Chris Rogers <[email protected]>
Reviewed by Kenneth Russell.
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (89473 => 89474)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2011-06-22 20:35:27 UTC (rev 89473)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2011-06-22 20:39:01 UTC (rev 89474)
@@ -3975,6 +3975,7 @@
return (renderer()->hasOverflowClip()
|| renderer()->hasReflection()
|| renderer()->hasMask()
+ || renderer()->isCanvas()
|| renderer()->isVideo()
|| renderer()->isEmbeddedObject()
|| renderer()->isApplet()
@@ -3992,6 +3993,7 @@
|| renderer()->hasReflection()
|| renderer()->hasMask()
|| renderer()->isTableRow()
+ || renderer()->isCanvas()
|| renderer()->isVideo()
|| renderer()->isEmbeddedObject()
|| renderer()->isApplet()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
