Title: [89475] trunk
- Revision
- 89475
- Author
- [email protected]
- Date
- 2011-06-22 13:43:11 -0700 (Wed, 22 Jun 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=63174
Don't draw the borders as one path unless there really are 4 borders
-and corresponding-
<rdar://problem/9457997>
Reviewed by Simon Fraser.
Source/WebCore:
If any of the border edges have no width, then allEdgesVisible should be set to
false since borders without width will not be visible.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
LayoutTests:
* fast/borders/only-one-border-with-width.html: Added.
* platform/mac/fast/borders/only-one-border-with-width-expected.png: Added.
* platform/mac/fast/borders/only-one-border-with-width-expected.txt: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (89474 => 89475)
--- trunk/LayoutTests/ChangeLog 2011-06-22 20:39:01 UTC (rev 89474)
+++ trunk/LayoutTests/ChangeLog 2011-06-22 20:43:11 UTC (rev 89475)
@@ -1,3 +1,16 @@
+2011-06-22 Beth Dakin <[email protected]>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=63174
+ Don't draw the borders as one path unless there really are 4 borders
+ -and corresponding-
+ <rdar://problem/9457997>
+
+ * fast/borders/only-one-border-with-width.html: Added.
+ * platform/mac/fast/borders/only-one-border-with-width-expected.png: Added.
+ * platform/mac/fast/borders/only-one-border-with-width-expected.txt: Added.
+
2011-06-22 Matthew Delaney <[email protected]>
Reviewed by Oliver Hunt.
Added: trunk/LayoutTests/fast/borders/only-one-border-with-width.html (0 => 89475)
--- trunk/LayoutTests/fast/borders/only-one-border-with-width.html (rev 0)
+++ trunk/LayoutTests/fast/borders/only-one-border-with-width.html 2011-06-22 20:43:11 UTC (rev 89475)
@@ -0,0 +1,25 @@
+<!DOCTYPE html>
+<html>
+<head>
+ <meta name="viewport" contents="width=device-width">
+ <style>
+
+ div {
+ margin: 20px;
+ box-sizing: border-box;
+ display: block;
+ width: 100px;
+ min-height: 50px;
+ border-right: 5px solid rgba(0, 0, 0, 0.15);
+ border-radius: 10px;
+ border-bottom-right-radius: 0px 0px;
+ border-top-right-radius: 0px 0px;
+ }
+ </style>
+</head>
+<body>
+ <!--This test passes if there is only a right border visible on the div below.-->
+ <div>
+ </div>
+</body>
+</html>
Added: trunk/LayoutTests/platform/mac/fast/borders/only-one-border-with-width-expected.png
(Binary files differ)
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/fast/borders/only-one-border-with-width-expected.txt (0 => 89475)
--- trunk/LayoutTests/platform/mac/fast/borders/only-one-border-with-width-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/borders/only-one-border-with-width-expected.txt 2011-06-22 20:43:11 UTC (rev 89475)
@@ -0,0 +1,6 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x90
+ RenderBlock {HTML} at (0,0) size 800x90
+ RenderBody {BODY} at (8,20) size 784x50
+ RenderBlock {DIV} at (20,0) size 100x50 [border: (5px solid #00000026) none]
Modified: trunk/Source/WebCore/ChangeLog (89474 => 89475)
--- trunk/Source/WebCore/ChangeLog 2011-06-22 20:39:01 UTC (rev 89474)
+++ trunk/Source/WebCore/ChangeLog 2011-06-22 20:43:11 UTC (rev 89475)
@@ -1,3 +1,17 @@
+2011-06-22 Beth Dakin <[email protected]>
+
+ Reviewed by Simon Fraser.
+
+ https://bugs.webkit.org/show_bug.cgi?id=63174
+ Don't draw the borders as one path unless there really are 4 borders
+ -and corresponding-
+ <rdar://problem/9457997>
+
+ If any of the border edges have no width, then allEdgesVisible should be set to
+ false since borders without width will not be visible.
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::paintBorder):
+
2011-06-22 Matthew Delaney <[email protected]>
Reviewed by Oliver Hunt.
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (89474 => 89475)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2011-06-22 20:39:01 UTC (rev 89474)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2011-06-22 20:43:11 UTC (rev 89475)
@@ -1383,8 +1383,10 @@
continue;
}
- if (!currEdge.width)
+ if (!currEdge.width) {
+ allEdgesVisible = false;
continue;
+ }
if (firstVisibleEdge == -1)
firstVisibleEdge = i;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
