Title: [90230] trunk/Tools
Revision
90230
Author
[email protected]
Date
2011-07-01 08:55:37 -0700 (Fri, 01 Jul 2011)

Log Message

Make TestFailures stop loading old builds once we've explained all current failures

We used to do this, but some refactoring in r90165 broke this logic.

Fixes <http://webkit.org/b/63808> REGRESSION (r90165): TestFailures page always loads all
builds back to the beginning of time

Reviewed by Dan Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
(LayoutTestHistoryAnalyzer.prototype.start): Stop fetching old builds once we're told that
all current failures have been explained.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js (90229 => 90230)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js	2011-07-01 15:21:02 UTC (rev 90229)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js	2011-07-01 15:55:37 UTC (rev 90230)
@@ -97,6 +97,9 @@
                 if (callbackRequestedStop)
                     return;
 
+                if (!callAgain)
+                    return;
+
                 if (analyzedAllBuilds) {
                     if (analyzedAllBuildsCallback)
                         analyzedAllBuildsCallback();

Modified: trunk/Tools/ChangeLog (90229 => 90230)


--- trunk/Tools/ChangeLog	2011-07-01 15:21:02 UTC (rev 90229)
+++ trunk/Tools/ChangeLog	2011-07-01 15:55:37 UTC (rev 90230)
@@ -1,5 +1,20 @@
 2011-07-01  Adam Roben  <[email protected]>
 
+        Make TestFailures stop loading old builds once we've explained all current failures
+
+        We used to do this, but some refactoring in r90165 broke this logic.
+
+        Fixes <http://webkit.org/b/63808> REGRESSION (r90165): TestFailures page always loads all
+        builds back to the beginning of time
+
+        Reviewed by Dan Bates.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
+        (LayoutTestHistoryAnalyzer.prototype.start): Stop fetching old builds once we're told that
+        all current failures have been explained.
+
+2011-07-01  Adam Roben  <[email protected]>
+
         commit-log-editor reorders ChangeLog entries in unexpected ways
         https://bugs.webkit.org/show_bug.cgi?id=63804
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to