Title: [90231] trunk
- Revision
- 90231
- Author
- [email protected]
- Date
- 2011-07-01 09:17:44 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Balazs Kelemen <[email protected]>
Reviewed by Andreas Kling.
[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
https://bugs.webkit.org/show_bug.cgi?id=63239
* platform/qt-wk2/Skipped:
2011-07-01 Balazs Kelemen <[email protected]>
Reviewed by Andreas Kling.
[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
https://bugs.webkit.org/show_bug.cgi?id=63239
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
Revert the return value of NPP_HandleEvent because the plugin function
returns with 0 if it handled the event.
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (90230 => 90231)
--- trunk/LayoutTests/ChangeLog 2011-07-01 15:55:37 UTC (rev 90230)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 16:17:44 UTC (rev 90231)
@@ -1,3 +1,12 @@
+2011-07-01 Balazs Kelemen <[email protected]>
+
+ Reviewed by Andreas Kling.
+
+ [X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
+ https://bugs.webkit.org/show_bug.cgi?id=63239
+
+ * platform/qt-wk2/Skipped:
+
2011-07-01 Alice Boxhall <[email protected]>
Reviewed by Adam Roben.
Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (90230 => 90231)
--- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-07-01 15:55:37 UTC (rev 90230)
+++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-07-01 16:17:44 UTC (rev 90231)
@@ -1491,7 +1491,6 @@
# Unexplained plugin failures
plugins/embed-prefers-plugins-for-images.html
-plugins/mouse-events-fixedpos.html
plugins/netscape-dom-access.html
plugins/npp-set-window-called-during-destruction.html
plugins/reloadplugins-and-pages.html
Modified: trunk/Source/WebKit2/ChangeLog (90230 => 90231)
--- trunk/Source/WebKit2/ChangeLog 2011-07-01 15:55:37 UTC (rev 90230)
+++ trunk/Source/WebKit2/ChangeLog 2011-07-01 16:17:44 UTC (rev 90231)
@@ -1,3 +1,19 @@
+2011-07-01 Balazs Kelemen <[email protected]>
+
+ Reviewed by Andreas Kling.
+
+ [X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
+ https://bugs.webkit.org/show_bug.cgi?id=63239
+
+ * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+ Revert the return value of NPP_HandleEvent because the plugin function
+ returns with 0 if it handled the event.
+ (WebKit::NetscapePlugin::platformHandleMouseEvent):
+ (WebKit::NetscapePlugin::platformHandleWheelEvent):
+ (WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
+ (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
+ (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
+
2011-07-01 Mark Rowe <[email protected]>
Unreviewed due to fixing of a broken world.
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp (90230 => 90231)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2011-07-01 15:55:37 UTC (rev 90230)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2011-07-01 16:17:44 UTC (rev 90231)
@@ -434,7 +434,7 @@
return false;
}
- return NPP_HandleEvent(&xEvent);
+ return !NPP_HandleEvent(&xEvent);
}
// We undefine these constants in npruntime_internal.h to avoid collision
@@ -453,7 +453,7 @@
initializeXEvent(xEvent);
setXButtonEventFieldsByWebWheelEvent(xEvent, event, m_frameRect.location());
- return NPP_HandleEvent(&xEvent);
+ return !NPP_HandleEvent(&xEvent);
}
void NetscapePlugin::platformSetFocus(bool focusIn)
@@ -480,7 +480,7 @@
initializeXEvent(xEvent);
setXCrossingEventFields(xEvent, event, m_frameRect.location(), EnterNotify);
- return NPP_HandleEvent(&xEvent);
+ return !NPP_HandleEvent(&xEvent);
}
bool NetscapePlugin::platformHandleMouseLeaveEvent(const WebMouseEvent& event)
@@ -492,7 +492,7 @@
initializeXEvent(xEvent);
setXCrossingEventFields(xEvent, event, m_frameRect.location(), LeaveNotify);
- return NPP_HandleEvent(&xEvent);
+ return !NPP_HandleEvent(&xEvent);
}
static inline void setXKeyEventFields(XEvent& xEvent, const WebKeyboardEvent& webEvent)
@@ -524,7 +524,7 @@
initializeXEvent(xEvent);
setXKeyEventFields(xEvent, event);
- return NPP_HandleEvent(&xEvent);
+ return !NPP_HandleEvent(&xEvent);
}
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
