Title: [90232] trunk/Source/_javascript_Core
- Revision
- 90232
- Author
- [email protected]
- Date
- 2011-07-01 09:18:48 -0700 (Fri, 01 Jul 2011)
Log Message
<http://webkit.org/b/63814> Fix clang build error in JITOpcodes32_64.cpp
Fixes the following build error in clang:
_javascript_Core/jit/JITOpcodes32_64.cpp:741:36:{741:9-741:35}: error: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Werror,-Wparentheses,3]
map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
_javascript_Core/jit/JITOpcodes32_64.cpp:741:36: note: place parentheses around the '+' _expression_ to silence this warning [3]
map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
^
( )
fix-it:"_javascript_Core/jit/JITOpcodes32_64.cpp":{741:9-741:9}:"("
fix-it:"_javascript_Core/jit/JITOpcodes32_64.cpp":{741:35-741:35}:")"
_javascript_Core/jit/JITOpcodes32_64.cpp:741:36:{741:28-741:94}: note: place parentheses around the '?:' _expression_ to evaluate it first [3]
map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve_global): Add parenthesis to make the
tertiary _expression_ evaluate first.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (90231 => 90232)
--- trunk/Source/_javascript_Core/ChangeLog 2011-07-01 16:17:44 UTC (rev 90231)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-07-01 16:18:48 UTC (rev 90232)
@@ -1,3 +1,27 @@
+2011-07-01 David Kilzer <[email protected]>
+
+ <http://webkit.org/b/63814> Fix clang build error in JITOpcodes32_64.cpp
+
+ Fixes the following build error in clang:
+
+ _javascript_Core/jit/JITOpcodes32_64.cpp:741:36:{741:9-741:35}: error: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Werror,-Wparentheses,3]
+ map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
+ _javascript_Core/jit/JITOpcodes32_64.cpp:741:36: note: place parentheses around the '+' _expression_ to silence this warning [3]
+ map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
+ ^
+ ( )
+ fix-it:"_javascript_Core/jit/JITOpcodes32_64.cpp":{741:9-741:9}:"("
+ fix-it:"_javascript_Core/jit/JITOpcodes32_64.cpp":{741:35-741:35}:")"
+ _javascript_Core/jit/JITOpcodes32_64.cpp:741:36:{741:28-741:94}: note: place parentheses around the '?:' _expression_ to evaluate it first [3]
+ map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
+ ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ 1 error generated.
+
+ * jit/JITOpcodes32_64.cpp:
+ (JSC::JIT::emit_op_resolve_global): Add parenthesis to make the
+ tertiary _expression_ evaluate first.
+
2011-07-01 Sheriff Bot <[email protected]>
Unreviewed, rolling out r90177 and r90179.
Modified: trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp (90231 => 90232)
--- trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp 2011-07-01 16:17:44 UTC (rev 90231)
+++ trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp 2011-07-01 16:18:48 UTC (rev 90232)
@@ -738,7 +738,7 @@
load32(BaseIndex(regT2, regT3, TimesEight, OBJECT_OFFSETOF(JSValue, u.asBits.payload)), regT0); // payload
load32(BaseIndex(regT2, regT3, TimesEight, OBJECT_OFFSETOF(JSValue, u.asBits.tag)), regT1); // tag
emitStore(dst, regT1, regT0);
- map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
+ map(m_bytecodeOffset + (dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global)), dst, regT1, regT0);
}
void JIT::emitSlow_op_resolve_global(Instruction* currentInstruction, Vector<SlowCaseEntry>::iterator& iter)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
