Title: [90277] trunk/Tools
- Revision
- 90277
- Author
- [email protected]
- Date
- 2011-07-01 14:21:07 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Adam Barth <[email protected]>
We shouldn't wait for ReportCrash while the timeout is running
https://bugs.webkit.org/show_bug.cgi?id=63837
Reviewed by Eric Seidel.
Instead, we should move this check to worker.py.
* Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
* Scripts/webkitpy/layout_tests/layout_package/worker.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (90276 => 90277)
--- trunk/Tools/ChangeLog 2011-07-01 21:09:03 UTC (rev 90276)
+++ trunk/Tools/ChangeLog 2011-07-01 21:21:07 UTC (rev 90277)
@@ -1,3 +1,15 @@
+2011-07-01 Adam Barth <[email protected]>
+
+ We shouldn't wait for ReportCrash while the timeout is running
+ https://bugs.webkit.org/show_bug.cgi?id=63837
+
+ Reviewed by Eric Seidel.
+
+ Instead, we should move this check to worker.py.
+
+ * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
+ * Scripts/webkitpy/layout_tests/layout_package/worker.py:
+
2011-07-01 Adam Roben <[email protected]>
Stop setting unsafe headers on POSTs via XHR from TestFailures page
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py (90276 => 90277)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py 2011-07-01 21:09:03 UTC (rev 90276)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py 2011-07-01 21:21:07 UTC (rev 90277)
@@ -125,11 +125,6 @@
return self._run_compare_test()
def _run_compare_test(self):
- # Before running the test, we wait for any crash reporters to finish
- # running. On Mac, ReportCrash chews up a bunch of resources and
- # causes the tests to become unstable, so we don't want to run in
- # parallel with ReportCrash.
- self._port.executive().wait_newest(self._port.is_crash_reporter)
driver_output = self._driver.run_test(self._driver_input())
expected_driver_output = self._expected_driver_output()
test_result = self._compare_output(driver_output, expected_driver_output)
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py (90276 => 90277)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py 2011-07-01 21:09:03 UTC (rev 90276)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py 2011-07-01 21:21:07 UTC (rev 90277)
@@ -126,6 +126,12 @@
self._done = True
def _run_test(self, test_input):
+ # Before running the test, we wait for any crash reporters to finish
+ # running. On Mac, ReportCrash chews up a bunch of resources and
+ # causes the tests to become unstable, so we don't want to run in
+ # parallel with ReportCrash.
+ self._port.executive().wait_newest(self._port.is_crash_reporter)
+
test_timeout_sec = self.timeout(test_input)
start = time.time()
self._worker_connection.post_message('started_test', test_input, test_timeout_sec)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
