Title: [90278] trunk/Tools
- Revision
- 90278
- Author
- [email protected]
- Date
- 2011-07-01 14:44:03 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Dmitry Lomov <[email protected]>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=63818
Test bots shouldn't attempt to build TestWebKitAPI on Windows.
TestWebKitAPI builds as a part of general webkit build and is a
part of build products archive.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* Scripts/run-api-tests:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (90277 => 90278)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-01 21:21:07 UTC (rev 90277)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-01 21:44:03 UTC (rev 90278)
@@ -316,6 +316,12 @@
descriptionDone = ["unit-tests"]
command = ["perl", "./Tools/Scripts/run-api-tests", WithProperties("--%(configuration)s"), "--verbose"]
+ def start(self):
+ platform = self.getProperty('platform')
+ if platform == 'win':
+ self.setCommand(self.command + ['--no-build'])
+ return shell.Test.start(self)
+
class RunPythonTests(shell.Test):
name = "webkitpy-test"
description = ["python-tests running"]
Modified: trunk/Tools/ChangeLog (90277 => 90278)
--- trunk/Tools/ChangeLog 2011-07-01 21:21:07 UTC (rev 90277)
+++ trunk/Tools/ChangeLog 2011-07-01 21:44:03 UTC (rev 90278)
@@ -1,3 +1,15 @@
+2011-07-01 Dmitry Lomov <[email protected]>
+
+ Reviewed by Adam Roben.
+
+ https://bugs.webkit.org/show_bug.cgi?id=63818
+ Test bots shouldn't attempt to build TestWebKitAPI on Windows.
+ TestWebKitAPI builds as a part of general webkit build and is a
+ part of build products archive.
+
+ * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+ * Scripts/run-api-tests:
+
2011-07-01 Adam Barth <[email protected]>
We shouldn't wait for ReportCrash while the timeout is running
Modified: trunk/Tools/Scripts/run-api-tests (90277 => 90278)
--- trunk/Tools/Scripts/run-api-tests 2011-07-01 21:21:07 UTC (rev 90277)
+++ trunk/Tools/Scripts/run-api-tests 2011-07-01 21:44:03 UTC (rev 90278)
@@ -51,6 +51,8 @@
my $showHelp = 0;
my $verbose = 0;
my $dump = 0;
+my $build = 1;
+my $buildDefault = $build ? "build" : "do not build";
my $programName = basename($0);
my $usage = <<EOF;
@@ -58,12 +60,14 @@
--help Show this help message
-v|--verbose Verbose output
-d|--dump-tests Dump the names of testcases without running them
+ --[no-]build Build (or do not build) unit tests prior to running (default: $buildDefault)
EOF
GetOptions(
'help' => \$showHelp,
'verbose|v' => \$verbose,
'dump|d' => \$dump,
+ 'build!' => \$build
);
if ($showHelp) {
@@ -72,7 +76,7 @@
}
setConfiguration();
-buildTestTool();
+buildTestTool() if $build;
setPathForRunningWebKitApp(\%ENV);
my %testsToRun = populateTests();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
