Title: [90279] trunk/Tools
- Revision
- 90279
- Author
- [email protected]
- Date
- 2011-07-01 14:47:44 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Adam Barth <[email protected]>
Temporarily disable waiting for ReportCrash to see how this code
affects performance on the bots.
* Scripts/webkitpy/layout_tests/layout_package/manager.py:
* Scripts/webkitpy/layout_tests/layout_package/worker.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (90278 => 90279)
--- trunk/Tools/ChangeLog 2011-07-01 21:44:03 UTC (rev 90278)
+++ trunk/Tools/ChangeLog 2011-07-01 21:47:44 UTC (rev 90279)
@@ -1,3 +1,11 @@
+2011-07-01 Adam Barth <[email protected]>
+
+ Temporarily disable waiting for ReportCrash to see how this code
+ affects performance on the bots.
+
+ * Scripts/webkitpy/layout_tests/layout_package/manager.py:
+ * Scripts/webkitpy/layout_tests/layout_package/worker.py:
+
2011-07-01 Dmitry Lomov <[email protected]>
Reviewed by Adam Roben.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py (90278 => 90279)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py 2011-07-01 21:44:03 UTC (rev 90278)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py 2011-07-01 21:47:44 UTC (rev 90279)
@@ -668,9 +668,10 @@
try:
while not self.is_done():
- if self._port.executive().running_pids(self._port.is_crash_reporter):
- self._printer.print_update("Waiting for crash reporter ...")
- self._port.executive().wait_newest(self._port.is_crash_reporter)
+ # Temporarily disabled to see how this code effect performance on the buildbots.
+ # if self._port.executive().running_pids(self._port.is_crash_reporter):
+ # self._printer.print_update("Waiting for crash reporter ...")
+ # self._port.executive().wait_newest(self._port.is_crash_reporter)
manager_connection.run_message_loop(delay_secs=1.0)
# Make sure all of the workers have shut down (if possible).
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py (90278 => 90279)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py 2011-07-01 21:44:03 UTC (rev 90278)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py 2011-07-01 21:47:44 UTC (rev 90279)
@@ -130,7 +130,9 @@
# running. On Mac, ReportCrash chews up a bunch of resources and
# causes the tests to become unstable, so we don't want to run in
# parallel with ReportCrash.
- self._port.executive().wait_newest(self._port.is_crash_reporter)
+ #
+ # Temporarily disabled to see how this code effect performance on the buildbots.
+ # self._port.executive().wait_newest(self._port.is_crash_reporter)
test_timeout_sec = self.timeout(test_input)
start = time.time()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
