Diff
Modified: trunk/Tools/ChangeLog (90879 => 90880)
--- trunk/Tools/ChangeLog 2011-07-13 02:34:54 UTC (rev 90879)
+++ trunk/Tools/ChangeLog 2011-07-13 02:39:16 UTC (rev 90880)
@@ -1,5 +1,27 @@
2011-07-12 Adam Barth <[email protected]>
+ garden-o-matic should label tests failures of new tests as such
+ https://bugs.webkit.org/show_bug.cgi?id=64421
+
+ Reviewed by Ojan Vafai.
+
+ Also, we shouldn't dim failures of new tests, even if we've only seen
+ them once because they're likely to be real problems that need
+ attention.
+
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Added.
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Added.
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
+ * Scripts/webkitpy/tool/servers/gardeningserver.py:
+
+2011-07-12 Adam Barth <[email protected]>
+
garden-o-matic should display how many times we've seen a failure
https://bugs.webkit.org/show_bug.cgi?id=64417
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js (90879 => 90880)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js 2011-07-13 02:34:54 UTC (rev 90879)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js 2011-07-13 02:39:16 UTC (rev 90880)
@@ -1,3 +1,5 @@
+(function () {
+
module("base");
test("joinPath", 1, function() {
@@ -92,3 +94,5 @@
}
});
});
+
+})();
Added: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js (0 => 90880)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js (rev 0)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js 2011-07-13 02:39:16 UTC (rev 90880)
@@ -0,0 +1,31 @@
+var checkout = checkout || {};
+
+(function() {
+
+var kWebKitTrunk = 'http://svn.webkit.org/repository/webkit/trunk/';
+
+function subversionURLAtRevision(subversionURL, revision)
+{
+ return subversionURL + '?r=' + revision;
+}
+
+checkout.subversionURLForTest = function(testName)
+{
+ return kWebKitTrunk + 'LayoutTests/' + testName;
+}
+
+checkout.existsAtRevision = function (subversionURL, revision, callback)
+{
+ $.ajax({
+ method: 'HEAD',
+ url: subversionURLAtRevision(subversionURL, revision),
+ success: function() {
+ callback(true);
+ },
+ error: function() {
+ callback(false);
+ }
+ });
+};
+
+})();
Added: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js (0 => 90880)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js (rev 0)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js 2011-07-13 02:39:16 UTC (rev 90880)
@@ -0,0 +1,9 @@
+(function () {
+
+module("checkout");
+
+test("subversionURLForTest", 1, function() {
+ equals(checkout.subversionURLForTest("path/to/test.html"), "http://svn.webkit.org/repository/webkit/trunk/LayoutTests/path/to/test.html");
+});
+
+})();
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html (90879 => 90880)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html 2011-07-13 02:34:54 UTC (rev 90879)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html 2011-07-13 02:39:16 UTC (rev 90880)
@@ -15,6 +15,7 @@
<script src=""
<script src=""
<script src=""
+<script src=""
<script src=""
<script src=""
<script src=""
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css (90879 => 90880)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css 2011-07-13 02:34:54 UTC (rev 90879)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css 2011-07-13 02:39:16 UTC (rev 90880)
@@ -41,7 +41,8 @@
}
/* If we've only seen a given test failure once, we dim it so as not to distract the gardener. */
-.test[data-failure-count="1"] {
+.test[data-failure-count="1"][data-new-test="false"] {
+ -webkit-transition: 1s opacity;
opacity: 0.5;
}
@@ -110,11 +111,15 @@
border-radius: 4px;
}
+.regression .test[data-new-test="true"] .what a[draggable]::after {
+ content: '(new)';
+ margin: 0 3px;
+}
+
.regression .what a {
padding: 1px 2px;
border-radius: 4px;
color: black;
- background-color: #f0f0f0;
}
.partytime {
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js (90879 => 90880)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js 2011-07-13 02:34:54 UTC (rev 90879)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js 2011-07-13 02:39:16 UTC (rev 90880)
@@ -30,6 +30,9 @@
var builderNameList = base.keys(resultNodesByBuilder);
results.unifyRegressionRanges(builderNameList, testName, function(oldestFailingRevision, newestPassingRevision) {
$('.when', testSummary).append(ui.summarizeRegressionRange(oldestFailingRevision, newestPassingRevision));
+ checkout.existsAtRevision(checkout.subversionURLForTest(testName), newestPassingRevision, function(testExistedBeforeFailure) {
+ $(testSummary).attr('data-new-test', !testExistedBeforeFailure);
+ });
});
results.countFailureOccurances(builderNameList, testName, function(failureCount) {
$(testSummary).attr('data-failure-count', failureCount);
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js (90879 => 90880)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js 2011-07-13 02:34:54 UTC (rev 90879)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js 2011-07-13 02:39:16 UTC (rev 90880)
@@ -1,3 +1,5 @@
+(function () {
+
module("results");
var kExampleResultsJSON = {
@@ -314,3 +316,5 @@
"http://build.chromium.org/f/chromium/layout_test_results/Mock_Builder/results/layout-test-results/userscripts/another-test-diff.txt",
]);
});
+
+})();
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html (90879 => 90880)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html 2011-07-13 02:34:54 UTC (rev 90879)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html 2011-07-13 02:39:16 UTC (rev 90880)
@@ -13,6 +13,8 @@
<ol id="qunit-tests"></ol>
<script src=""
<script src=""
+<script src=""
+<script src=""
<script src=""
<script src=""
<script src=""
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js (90879 => 90880)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js 2011-07-13 02:34:54 UTC (rev 90879)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js 2011-07-13 02:39:16 UTC (rev 90880)
@@ -1,3 +1,5 @@
+(function () {
+
module("iu");
var kExampleResultsByTest = {
@@ -62,3 +64,5 @@
'<img src="" class="actual">' +
'<img src="" class="diff">');
});
+
+})();
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py (90879 => 90880)
--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py 2011-07-13 02:34:54 UTC (rev 90879)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py 2011-07-13 02:39:16 UTC (rev 90880)
@@ -37,16 +37,17 @@
class GardeningHTTPRequestHandler(ReflectionHandler):
STATIC_FILE_NAMES = frozenset([
+ "base.js",
+ "checkout.js",
+ "config.js",
+ "favicon-green.png",
+ "favicon-red.png",
"index.html",
"main.css",
+ "main.js",
"partytime.gif",
- "base.js",
- "config.js",
- "main.js",
"results.js",
"ui.js",
- "favicon-green.png",
- "favicon-red.png",
])
STATIC_FILE_DIRECTORY = os.path.join(os.path.dirname(__file__), "data", "gardeningserver")
