Title: [90881] trunk/Tools
- Revision
- 90881
- Author
- [email protected]
- Date
- 2011-07-12 19:41:21 -0700 (Tue, 12 Jul 2011)
Log Message
Adjust garden-o-matic layout to use fewer lines
https://bugs.webkit.org/show_bug.cgi?id=64422
Reviewed by Ojan Vafai.
This patch effectively merges the test name line with the list of
builders on which the test fails. Each test failure now occupies two
lines instead of three.
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (90880 => 90881)
--- trunk/Tools/ChangeLog 2011-07-13 02:39:16 UTC (rev 90880)
+++ trunk/Tools/ChangeLog 2011-07-13 02:41:21 UTC (rev 90881)
@@ -1,5 +1,20 @@
2011-07-12 Adam Barth <[email protected]>
+ Adjust garden-o-matic layout to use fewer lines
+ https://bugs.webkit.org/show_bug.cgi?id=64422
+
+ Reviewed by Ojan Vafai.
+
+ This patch effectively merges the test name line with the list of
+ builders on which the test fails. Each test failure now occupies two
+ lines instead of three.
+
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
+
+2011-07-12 Adam Barth <[email protected]>
+
garden-o-matic should label tests failures of new tests as such
https://bugs.webkit.org/show_bug.cgi?id=64421
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css (90880 => 90881)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css 2011-07-13 02:39:16 UTC (rev 90880)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css 2011-07-13 02:41:21 UTC (rev 90881)
@@ -57,6 +57,7 @@
.regression ul {
margin: 0;
list-style: none;
+ display: inline-block;
padding: 0 0 0 10px;
}
@@ -135,11 +136,11 @@
color: #555;
}
-.regression .when, .regression .how-many {
+.regression .regression-range, .regression .failure-count {
padding: 0px 2px;
display: inline-block;
}
-.regression .how-many {
+.regression .failure-count {
color: #555;
}
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js (90880 => 90881)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js 2011-07-13 02:39:16 UTC (rev 90880)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js 2011-07-13 02:41:21 UTC (rev 90881)
@@ -29,14 +29,14 @@
var builderNameList = base.keys(resultNodesByBuilder);
results.unifyRegressionRanges(builderNameList, testName, function(oldestFailingRevision, newestPassingRevision) {
- $('.when', testSummary).append(ui.summarizeRegressionRange(oldestFailingRevision, newestPassingRevision));
+ $('.regression-range', testSummary).append(ui.summarizeRegressionRange(oldestFailingRevision, newestPassingRevision));
checkout.existsAtRevision(checkout.subversionURLForTest(testName), newestPassingRevision, function(testExistedBeforeFailure) {
$(testSummary).attr('data-new-test', !testExistedBeforeFailure);
});
});
results.countFailureOccurances(builderNameList, testName, function(failureCount) {
$(testSummary).attr('data-failure-count', failureCount);
- $('.how-many', testSummary).text(ui.failureCount(failureCount));
+ $('.failure-count', testSummary).text(ui.failureCount(failureCount));
});
});
$('.results').append(regressions);
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js (90880 => 90881)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js 2011-07-13 02:39:16 UTC (rev 90880)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js 2011-07-13 02:41:21 UTC (rev 90881)
@@ -32,8 +32,10 @@
'<span class="what"><a draggable></a></span>' +
'<span>fails on</span>' +
'<ul class="where"></ul>' +
- '<div class="when"></div>' +
- '<div class="how-many"></div>' +
+ '<div class="when">' +
+ '<div class="regression-range"></div>' +
+ '<div class="failure-count"></div>' +
+ '</div>' +
'</div>');
$('.what a', block).text(testName).attr('href', ui.urlForTest(testName)).attr('class', unexpectedResults.join(' '));
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
