Diff
Modified: trunk/Source/WebCore/ChangeLog (90924 => 90925)
--- trunk/Source/WebCore/ChangeLog 2011-07-13 17:01:38 UTC (rev 90924)
+++ trunk/Source/WebCore/ChangeLog 2011-07-13 17:02:48 UTC (rev 90925)
@@ -1,3 +1,28 @@
+2011-07-12 Simon Fraser <simon.fra...@apple.com>
+
+ Rename compositing-related updateContentsScale() methods
+ https://bugs.webkit.org/show_bug.cgi?id=64430
+
+ Reviewed by Joseph Pecoraro.
+
+ Rename updateContentsScale() to something less presumptuous; layers may choose
+ to do something other than update their contents scale when the page scale factor
+ changes. pageScaleFactorChanged() is a better name.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::pageScaleFactorChanged):
+ (WebCore::Frame::scalePage):
+ * page/Frame.h:
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::pageScaleFactorChanged):
+ * rendering/RenderLayer.h:
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::pageScaleFactorChanged):
+ * rendering/RenderLayerBacking.h:
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::pageScaleFactorChanged):
+ * rendering/RenderLayerCompositor.h:
+
2011-07-13 Pierre Rossi <pierre.ro...@gmail.com>
Fix compile for QRawFont.
Modified: trunk/Source/WebCore/page/Frame.cpp (90924 => 90925)
--- trunk/Source/WebCore/page/Frame.cpp 2011-07-13 17:01:38 UTC (rev 90924)
+++ trunk/Source/WebCore/page/Frame.cpp 2011-07-13 17:02:48 UTC (rev 90925)
@@ -1104,14 +1104,14 @@
}
#if USE(ACCELERATED_COMPOSITING)
-void Frame::updateContentsScale(float scale)
+void Frame::pageScaleFactorChanged(float scale)
{
for (Frame* child = tree()->firstChild(); child; child = child->tree()->nextSibling())
- child->updateContentsScale(scale);
+ child->pageScaleFactorChanged(scale);
RenderView* root = contentRenderer();
if (root && root->compositor())
- root->compositor()->updateContentsScale(scale);
+ root->compositor()->pageScaleFactorChanged(scale);
}
#endif
@@ -1130,7 +1130,7 @@
document->recalcStyle(Node::Force);
#if USE(ACCELERATED_COMPOSITING)
- updateContentsScale(scale);
+ pageScaleFactorChanged(scale);
#endif
}
Modified: trunk/Source/WebCore/page/Frame.h (90924 => 90925)
--- trunk/Source/WebCore/page/Frame.h 2011-07-13 17:01:38 UTC (rev 90924)
+++ trunk/Source/WebCore/page/Frame.h 2011-07-13 17:02:48 UTC (rev 90925)
@@ -220,7 +220,7 @@
void lifeSupportTimerFired(Timer<Frame>*);
#if USE(ACCELERATED_COMPOSITING)
- void updateContentsScale(float);
+ void pageScaleFactorChanged(float);
#endif
HashSet<FrameDestructionObserver*> m_destructionObservers;
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (90924 => 90925)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2011-07-13 17:01:38 UTC (rev 90924)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2011-07-13 17:02:48 UTC (rev 90925)
@@ -4165,11 +4165,11 @@
m_reflection->setStyle(newStyle.release());
}
-void RenderLayer::updateContentsScale(float scale)
+void RenderLayer::pageScaleFactorChanged(float scale)
{
#if USE(ACCELERATED_COMPOSITING)
if (m_backing)
- m_backing->updateContentsScale(scale);
+ m_backing->pageScaleFactorChanged(scale);
#endif
}
Modified: trunk/Source/WebCore/rendering/RenderLayer.h (90924 => 90925)
--- trunk/Source/WebCore/rendering/RenderLayer.h 2011-07-13 17:01:38 UTC (rev 90924)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2011-07-13 17:02:48 UTC (rev 90925)
@@ -613,7 +613,7 @@
void setMustOverlapCompositedLayers(bool b) { m_mustOverlapCompositedLayers = b; }
#endif
- void updateContentsScale(float);
+ void pageScaleFactorChanged(float);
friend class RenderLayerBacking;
friend class RenderLayerCompositor;
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (90924 => 90925)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2011-07-13 17:01:38 UTC (rev 90924)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2011-07-13 17:02:48 UTC (rev 90925)
@@ -1475,7 +1475,7 @@
return ContainerCompositingLayer;
}
-void RenderLayerBacking::updateContentsScale(float scale)
+void RenderLayerBacking::pageScaleFactorChanged(float scale)
{
float combinedScale = scale * backingScaleFactor();
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.h (90924 => 90925)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.h 2011-07-13 17:01:38 UTC (rev 90924)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.h 2011-07-13 17:02:48 UTC (rev 90925)
@@ -136,7 +136,7 @@
// For informative purposes only.
CompositingLayerType compositingLayerType() const;
- void updateContentsScale(float);
+ void pageScaleFactorChanged(float);
GraphicsLayer* layerForHorizontalScrollbar() const { return m_layerForHorizontalScrollbar.get(); }
GraphicsLayer* layerForVerticalScrollbar() const { return m_layerForVerticalScrollbar.get(); }
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (90924 => 90925)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2011-07-13 17:01:38 UTC (rev 90924)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2011-07-13 17:02:48 UTC (rev 90925)
@@ -1845,31 +1845,31 @@
return false;
}
-void RenderLayerCompositor::updateContentsScale(float scale, RenderLayer* layer)
+void RenderLayerCompositor::pageScaleFactorChanged(float scale, RenderLayer* layer)
{
if (!layer)
layer = rootRenderLayer();
- layer->updateContentsScale(scale);
+ layer->pageScaleFactorChanged(scale);
if (layer->isStackingContext()) {
if (Vector<RenderLayer*>* negZOrderList = layer->negZOrderList()) {
size_t listSize = negZOrderList->size();
for (size_t i = 0; i < listSize; ++i)
- updateContentsScale(scale, negZOrderList->at(i));
+ pageScaleFactorChanged(scale, negZOrderList->at(i));
}
if (Vector<RenderLayer*>* posZOrderList = layer->posZOrderList()) {
size_t listSize = posZOrderList->size();
for (size_t i = 0; i < listSize; ++i)
- updateContentsScale(scale, posZOrderList->at(i));
+ pageScaleFactorChanged(scale, posZOrderList->at(i));
}
}
if (Vector<RenderLayer*>* normalFlowList = layer->normalFlowList()) {
size_t listSize = normalFlowList->size();
for (size_t i = 0; i < listSize; ++i)
- updateContentsScale(scale, normalFlowList->at(i));
+ pageScaleFactorChanged(scale, normalFlowList->at(i));
}
}
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.h (90924 => 90925)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.h 2011-07-13 17:01:38 UTC (rev 90924)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.h 2011-07-13 17:02:48 UTC (rev 90925)
@@ -184,7 +184,7 @@
bool compositorShowDebugBorders() const { return m_showDebugBorders; }
bool compositorShowRepaintCounter() const { return m_showRepaintCounter; }
- void updateContentsScale(float, RenderLayer* = 0);
+ void pageScaleFactorChanged(float, RenderLayer* = 0);
GraphicsLayer* layerForHorizontalScrollbar() const { return m_layerForHorizontalScrollbar.get(); }
GraphicsLayer* layerForVerticalScrollbar() const { return m_layerForVerticalScrollbar.get(); }
