Title: [90926] trunk/Tools
- Revision
- 90926
- Author
- [email protected]
- Date
- 2011-07-13 10:02:57 -0700 (Wed, 13 Jul 2011)
Log Message
Remove "Dismiss" button from garden-o-matic butterbar
https://bugs.webkit.org/show_bug.cgi?id=64443
Reviewed by Dimitri Glazkov.
We don't have any persistent butter bar messages yet, so the dismiss
button is premature (and fairly heavy, visually).
* Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (90925 => 90926)
--- trunk/Tools/ChangeLog 2011-07-13 17:02:48 UTC (rev 90925)
+++ trunk/Tools/ChangeLog 2011-07-13 17:02:57 UTC (rev 90926)
@@ -1,5 +1,18 @@
2011-07-13 Adam Barth <[email protected]>
+ Remove "Dismiss" button from garden-o-matic butterbar
+ https://bugs.webkit.org/show_bug.cgi?id=64443
+
+ Reviewed by Dimitri Glazkov.
+
+ We don't have any persistent butter bar messages yet, so the dismiss
+ button is premature (and fairly heavy, visually).
+
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
+
+2011-07-13 Adam Barth <[email protected]>
+
Refine garden-o-matic status pane
https://bugs.webkit.org/show_bug.cgi?id=64442
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html (90925 => 90926)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html 2011-07-13 17:02:48 UTC (rev 90925)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html 2011-07-13 17:02:57 UTC (rev 90926)
@@ -10,7 +10,7 @@
<link rel="icon" id="favicon" type="image/png" href=""
</head>
<body>
-<div class="butterbar"><span class="status">Loading...</span> <a class="dismiss" href=""
+<div class="butterbar"><span class="status">Loading...</span></div>
<div class="results"></div>
<div class="results-detail">
<div class="toolbar"><span class="status"></span> <a class="dismiss" href="" class="content"></div></div>
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js (90925 => 90926)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js 2011-07-13 17:02:48 UTC (rev 90925)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js 2011-07-13 17:02:57 UTC (rev 90926)
@@ -2,7 +2,7 @@
function dismissButterbar()
{
- $('.butterbar').fadeOut();
+ $('.butterbar').fadeOut('fast');
}
function displayOnButterbar(message)
@@ -65,7 +65,7 @@
if ($('.results', content).attr(config.kBuilderNameAttr) == builderName && $('.results', content).attr(config.kTestNameAttr) == testName)
return;
- displayOnButterbar('Loading results');
+ displayOnButterbar('Loading...');
results.fetchResultsURLs(builderName, testName, failureTypeList, function(resultsURLs) {
var status = $('.results-detail .toolbar .status');
@@ -101,7 +101,6 @@
});
}
-$('.butterbar .dismiss').live('click', dismissButterbar);
$('.regression .where li').live('mouseenter', showResultsDetail);
$('.results-detail .dismiss').live('click', hideResultsDetail);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
