Title: [91711] trunk/Tools
- Revision
- 91711
- Author
- [email protected]
- Date
- 2011-07-25 15:32:42 -0700 (Mon, 25 Jul 2011)
Log Message
simplify the UI of the header above the test list table
https://bugs.webkit.org/show_bug.cgi?id=65136
Reviewed by Adam Barth.
Use checkboxes instead of links since this is really about which tests to include.
Ends up using less text and put the checkboxes to the right of the header instead of below it.
* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (91710 => 91711)
--- trunk/Tools/ChangeLog 2011-07-25 22:23:50 UTC (rev 91710)
+++ trunk/Tools/ChangeLog 2011-07-25 22:32:42 UTC (rev 91711)
@@ -1,3 +1,16 @@
+2011-07-25 Ojan Vafai <[email protected]>
+
+ simplify the UI of the header above the test list table
+ https://bugs.webkit.org/show_bug.cgi?id=65136
+
+ Reviewed by Adam Barth.
+
+ Use checkboxes instead of links since this is really about which tests to include.
+ Ends up using less text and put the checkboxes to the right of the header instead of below it.
+
+ * TestResultServer/static-dashboards/flakiness_dashboard.html:
+ * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
+
2011-07-25 Chris Rogers <[email protected]>
Update new-run-webkit-tests to accomodate binary audio data
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html (91710 => 91711)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-25 22:23:50 UTC (rev 91710)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-25 22:32:42 UTC (rev 91711)
@@ -47,6 +47,9 @@
input {
margin-right: 15px;
}
+label {
+ padding-left: 2em;
+}
.forms {
display: -webkit-box;
}
@@ -2338,13 +2341,28 @@
return html;
}
+function checkBoxToToggleState(key, text)
+{
+ var stateEnabled = g_currentState[key];
+ return '<label><input type=checkbox ' + (stateEnabled ? 'checked ' : '') + '_onclick_="setQueryParameter(\'' + key + '\', ' + !stateEnabled + ')">' + text + '</label>';
+}
+
function linkHTMLToToggleState(key, linkText)
{
- var isTrue = g_currentState[key];
- return '<span class=link _onclick_="setQueryParameter(\'' + key + '\', ' +
- !isTrue + ')">' + (isTrue ? 'Hide' : 'Show') + ' ' + linkText + '</span>';
+ var stateEnabled = g_currentState[key];
+ return '<span class=link _onclick_="setQueryParameter(\'' + key + '\', ' + !stateEnabled + ')">' + (stateEnabled ? 'Hide' : 'Show') + ' ' + linkText + '</span>';
}
+function headerForTestTableHtml()
+{
+ return '<h2 style="display:inline-block">Failing tests</h2>' +
+ checkBoxToToggleState('showWontFixSkip', 'WONTFIX/SKIP') +
+ checkBoxToToggleState('showCorrectExpectations', 'tests with correct expectations') +
+ checkBoxToToggleState('showWrongExpectations', 'tests with wrong expectations') +
+ checkBoxToToggleState('showFlaky', 'flaky') +
+ checkBoxToToggleState('showSlow', 'slow');
+}
+
function generatePageForBuilder(builderName)
{
processTestRunsForBuilder(builderName);
@@ -2368,17 +2386,10 @@
var html = htmlForNavBar();
- if (isLayoutTestResults()) {
- html += htmlForTestsWithExpectationsButNoFailures(builderName) +
- '<h2>Failing tests</h2>' +
- linkHTMLToToggleState('showWontFixSkip', 'WONTFIX/SKIP') + ' | ' +
- linkHTMLToToggleState('showCorrectExpectations', 'tests with correct expectations') + ' | ' +
- linkHTMLToToggleState('showWrongExpectations', 'tests with wrong expectations') + ' | ' +
- linkHTMLToToggleState('showFlaky', 'flaky') + ' | ' +
- linkHTMLToToggleState('showSlow', 'slow');
- }
+ if (isLayoutTestResults())
+ html += htmlForTestsWithExpectationsButNoFailures(builderName) + headerForTestTableHtml();
- html += ' | All columns are sortable. | Flakiness reader order is newer --> older runs.<br>' + testsHTML;
+ html += '<br>' + testsHTML;
appendHTML(html);
var ths = document.getElementsByTagName('th');
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js (91710 => 91711)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js 2011-07-25 22:23:50 UTC (rev 91710)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js 2011-07-25 22:32:42 UTC (rev 91711)
@@ -355,6 +355,12 @@
assertEquals(container.querySelectorAll('#skipped-tests > div').length, 0);
}
+function testHeaderForTestTableHtml()
+{
+ var container = document.createElement('div');
+ container.innerHTML = headerForTestTableHtml();
+ assertEquals(container.querySelectorAll('input').length, 5);
+}
function runTests()
{
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
