Modified: trunk/Tools/ChangeLog (91711 => 91712)
--- trunk/Tools/ChangeLog 2011-07-25 22:32:42 UTC (rev 91711)
+++ trunk/Tools/ChangeLog 2011-07-25 22:33:45 UTC (rev 91712)
@@ -1,5 +1,18 @@
2011-07-25 Ojan Vafai <[email protected]>
+ always show flakiness details on the builder page
+ https://bugs.webkit.org/show_bug.cgi?id=65139
+
+ Reviewed by Tony Chang.
+
+ In order to simplify the UI, we hide the flakiness details by default,
+ but there's no actual use-case for this page without the flakiness details.
+ So get rid of that option and always show the flakiness details.
+
+ * TestResultServer/static-dashboards/flakiness_dashboard.html:
+
+2011-07-25 Ojan Vafai <[email protected]>
+
simplify the UI of the header above the test list table
https://bugs.webkit.org/show_bug.cgi?id=65136
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html (91711 => 91712)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-25 22:32:42 UTC (rev 91711)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-25 22:33:45 UTC (rev 91712)
@@ -426,7 +426,6 @@
case 'showUnexpectedPasses':
case 'showWontFixSkip':
case 'expectationsUpdate':
- case 'showRunsOnBuilderPage':
g_currentState[key] = value == 'true';
return true;
@@ -449,7 +448,6 @@
showSkipped: !isLayoutTestResults(),
showUnexpectedPasses: !isLayoutTestResults(),
expectationsUpdate: false,
- showRunsOnBuilderPage: false,
updateIndex: 0,
builder: g_defaultBuilderName,
resultsHeight: 300,
@@ -1273,9 +1271,6 @@
function htmlForTestResults(test)
{
- if (!g_currentState.showRunsOnBuilderPage && !isCrossBuilderView())
- return '<td>' + test.flips;
-
var html = '';
var results = test.rawResults.concat();
var times = test.rawTimes.concat();
@@ -1410,23 +1405,10 @@
if (!isCrossBuilderView() || opt_getAll)
headers.push('test');
- if (isLayoutTestResults() || opt_getAll) {
- headers.push('bugs');
- if (isCrossBuilderView() || g_currentState.showRunsOnBuilderPage || opt_getAll)
- headers.push('modifiers', 'expectations');
- }
+ if (isLayoutTestResults() || opt_getAll)
+ headers.push('bugs', 'modifiers', 'expectations');
- headers.push('slowest run', '% fail');
-
- var FLAKINESS_HEADER = 'flakiness (numbers are runtimes in seconds)';
- var FLIPS_HEADER = 'flakiness (number of flips)';
-
- if (g_currentState.showRunsOnBuilderPage || opt_getAll)
- headers.push(FLAKINESS_HEADER);
-
- if (!g_currentState.showRunsOnBuilderPage || opt_getAll)
- headers.push(FLIPS_HEADER);
-
+ headers.push('slowest run', '% fail', 'flakiness (numbers are runtimes in seconds)');
return headers;
}
@@ -2322,9 +2304,6 @@
function htmlForNavBar()
{
var extraHTML = '';
- if (!isCrossBuilderView())
- extraHTML += checkboxHTML('showRunsOnBuilderPage', 'Show flakiness details', g_currentState.showRunsOnBuilderPage);
-
var html = htmlForTestTypeSwitcher(false, extraHTML, isCrossBuilderView());
html += '<div class=forms><form id=result-form ' +
'_onsubmit_="setQueryParameter(\'result\', result.value);' +
