Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (94309 => 94310)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-09-01 17:48:59 UTC (rev 94309)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-09-01 17:51:12 UTC (rev 94310)
@@ -109,7 +109,7 @@
linkToRevision.href = ""
linkToRevision.target = '_blank';
linkToRevision.textContent = commitData.revision;
- this._addDescriptionPart('title', commitData);
+ this._addDescriptionPart('summary', commitData);
this._addDescriptionPart('author', commitData);
this._addDescriptionPart('reviewer', commitData);
},
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (94309 => 94310)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-09-01 17:48:59 UTC (rev 94309)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-09-01 17:51:12 UTC (rev 94310)
@@ -83,12 +83,12 @@
});
test('SuspiciousCommit', 2, function() {
- var suspiciousCommit = new ui.notifications.SuspiciousCommit({revision: 1, title: "title", author: "author", reviewer: "reviewer"});
+ var suspiciousCommit = new ui.notifications.SuspiciousCommit({revision: 1, summary: "summary", author: "author", reviewer: "reviewer"});
equal(suspiciousCommit.tagName, 'LI');
equal(suspiciousCommit.innerHTML,
'<div class="description">' +
'<a href="" target="_blank">1</a>' +
- '<span class="title">title</span>' +
+ '<span class="summary">summary</span>' +
'<span class="author">author</span>' +
'<span class="reviewer">reviewer</span>' +
'</div>' +
@@ -172,7 +172,7 @@
deepEqual(testFailures.testNameList(), ['test']);
var time = new Date();
time.setMinutes(time.getMinutes() - 10);
- testFailures.addCommitData({revision: 1, time: time, title: "title", author: "author", reviewer: "reviewer"});
+ testFailures.addCommitData({revision: 1, time: time, summary: "summary", author: "author", reviewer: "reviewer"});
equal(testFailures.index(), time.getTime());
equal(testFailures.innerHTML,
'<div class="how">' +
@@ -195,7 +195,7 @@
'<li>' +
'<div class="description">' +
'<a href="" target="_blank">1</a>' +
- '<span class="title">title</span>' +
+ '<span class="summary">summary</span>' +
'<span class="author">author</span>' +
'<span class="reviewer">reviewer</span>' +
'</div>' +
@@ -236,7 +236,7 @@
'<li>' +
'<div class="description">' +
'<a href="" target="_blank">1</a>' +
- '<span class="title">title</span>' +
+ '<span class="summary">summary</span>' +
'<span class="author">author</span>' +
'<span class="reviewer">reviewer</span>' +
'</div>' +
@@ -281,7 +281,7 @@
'<li>' +
'<div class="description">' +
'<a href="" target="_blank">1</a>' +
- '<span class="title">title</span>' +
+ '<span class="summary">summary</span>' +
'<span class="author">author</span>' +
'<span class="reviewer">reviewer</span>' +
'</div>' +
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css (94309 => 94310)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2011-09-01 17:48:59 UTC (rev 94309)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2011-09-01 17:51:12 UTC (rev 94310)
@@ -58,6 +58,11 @@
-webkit-box-flex: 1;
}
+ ol.notifications>li div.what ul.effects>li.builder-name {
+ display: inline;
+ padding-left: 10px;
+ }
+
ol.notifications ul.causes>li, ol.notifications div.problem {
display: -webkit-box;
}
@@ -66,13 +71,19 @@
-webkit-box-flex: 1;
}
-ol.notifications div.problem {
+ol.notifications>li div.problem {
padding: 0 10px 10px 0;
}
-ol.notifications ul.causes>li {
- border-top: 1px solid LightGray;
- padding: 10px 20px 10px 0;
+ ol.notifications>li div.problem>ul.actions {
+ visibility: hidden;
+ }
+
+ ol.notifications>li:hover div.problem>ul.actions {
+ visibility: visible;
+ }
+
+ol.notifications>li ul.causes>li>ul.actions {
}
ol.notifications>li ul.causes>li>div.description {
@@ -108,6 +119,10 @@
display: inline-block;
}
+ ol.notifications>li ul.causes>li>div.description>span.author {
+ font-style: italic;
+ }
+
ol.notifications>li ul.causes>li>div.description>span.reviewer {
color: Gray;
}
@@ -121,8 +136,13 @@
}
ol.notifications>li ul.causes>li>ul.actions {
+ visibility: hidden;
}
+ ol.notifications>li ul.causes>li:hover>ul.actions {
+ visibility: visible;
+ }
+
ol.notifications>li ul.causes>li li {
padding: 10px 0 0 0;
display: inline;
Modified: trunk/Tools/ChangeLog (94309 => 94310)
--- trunk/Tools/ChangeLog 2011-09-01 17:48:59 UTC (rev 94309)
+++ trunk/Tools/ChangeLog 2011-09-01 17:51:12 UTC (rev 94310)
@@ -1,5 +1,24 @@
2011-09-01 Adam Barth <[email protected]>
+ Switch garden-o-matic from commitData.title to commitData.summary
+ https://bugs.webkit.org/show_bug.cgi?id=67375
+
+ Reviewed by Dimitri Glazkov.
+
+ commitData.title is a string provided by Trac, which isn't great in all
+ cases. commitData.summary is my attempt to find the most important
+ one-line summary of the commit. This patch switches garden-o-matic
+ over to summary.
+
+ Also, this patch tweaks a bunch of CSS to tighten up the summary page
+ and reduce visual noise.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
+
+2011-09-01 Adam Barth <[email protected]>
+
Group failing tests in garden-o-matic if there are more than three in a folder
https://bugs.webkit.org/show_bug.cgi?id=67373
