Title: [94311] trunk/Tools
- Revision
- 94311
- Author
- [email protected]
- Date
- 2011-09-01 10:53:06 -0700 (Thu, 01 Sep 2011)
Log Message
Hide garden-o-matic failure table until hover
https://bugs.webkit.org/show_bug.cgi?id=67376
Reviewed by Dimitri Glazkov.
This patch removes the failure table for build failures (because it
does not make sense) and hides the failure table for test groups until
the user hovers over the test failure block, reducing visual noise.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (94310 => 94311)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-09-01 17:51:12 UTC (rev 94310)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js 2011-09-01 17:53:06 UTC (rev 94311)
@@ -209,6 +209,7 @@
init: function()
{
this._problem.insertBefore(document.createTextNode('Build Failed:'), this._problem.firstChild);
+ $(this._where).detach();
},
setFailingBuilders: function(builderNameList)
{
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (94310 => 94311)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-09-01 17:51:12 UTC (rev 94310)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js 2011-09-01 17:53:06 UTC (rev 94311)
@@ -329,10 +329,6 @@
equal(builderFailing.innerHTML,
'<div class="how">' +
'<time class="relative">Just now</time>' +
- '<table class="failures">' +
- '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
- '<tbody><tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr></tbody>' +
- '</table>' +
'</div>' +
'<div class="what">' +
'<div class="problem">Build Failed:' +
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css (94310 => 94311)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2011-09-01 17:51:12 UTC (rev 94310)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css 2011-09-01 17:53:06 UTC (rev 94311)
@@ -72,7 +72,7 @@
}
ol.notifications>li div.problem {
- padding: 0 10px 10px 0;
+ padding-bottom: 10px;
}
ol.notifications>li div.problem>ul.actions {
@@ -83,6 +83,14 @@
visibility: visible;
}
+ ol.notifications>li table.failures {
+ visibility: hidden;
+ }
+
+ ol.notifications>li:hover table.failures {
+ visibility: visible;
+ }
+
ol.notifications>li ul.causes>li>ul.actions {
}
Modified: trunk/Tools/ChangeLog (94310 => 94311)
--- trunk/Tools/ChangeLog 2011-09-01 17:51:12 UTC (rev 94310)
+++ trunk/Tools/ChangeLog 2011-09-01 17:53:06 UTC (rev 94311)
@@ -1,5 +1,20 @@
2011-09-01 Adam Barth <[email protected]>
+ Hide garden-o-matic failure table until hover
+ https://bugs.webkit.org/show_bug.cgi?id=67376
+
+ Reviewed by Dimitri Glazkov.
+
+ This patch removes the failure table for build failures (because it
+ does not make sense) and hides the failure table for test groups until
+ the user hovers over the test failure block, reducing visual noise.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
+
+2011-09-01 Adam Barth <[email protected]>
+
Switch garden-o-matic from commitData.title to commitData.summary
https://bugs.webkit.org/show_bug.cgi?id=67375
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
