Title: [97022] trunk/Source/_javascript_Core
- Revision
- 97022
- Author
- [email protected]
- Date
- 2011-10-09 01:08:48 -0700 (Sun, 09 Oct 2011)
Log Message
Remove 32 bit restrictions in DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69711
Patch by Yuqiang Xian <[email protected]> on 2011-10-09
Reviewed by Filip Pizlo.
op_call/op_construct support was disabled for 32 bit DFG JIT because
there was regression in _javascript_core tests. Now the bugs are fixed
and there should be no regression. This makes 32 bit DFG have the same
capability as 64 bit DFG, and improves the coverage.
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97021 => 97022)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-09 07:23:28 UTC (rev 97021)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-09 08:08:48 UTC (rev 97022)
@@ -1,3 +1,18 @@
+2011-10-09 Yuqiang Xian <[email protected]>
+
+ Remove 32 bit restrictions in DFG JIT
+ https://bugs.webkit.org/show_bug.cgi?id=69711
+
+ Reviewed by Filip Pizlo.
+
+ op_call/op_construct support was disabled for 32 bit DFG JIT because
+ there was regression in _javascript_core tests. Now the bugs are fixed
+ and there should be no regression. This makes 32 bit DFG have the same
+ capability as 64 bit DFG, and improves the coverage.
+
+ * dfg/DFGCapabilities.h:
+ (JSC::DFG::canCompileOpcode):
+
2011-10-08 Mark Hahnenberg <[email protected]>
Add static version of JSCell::getConstructData
Modified: trunk/Source/_javascript_Core/dfg/DFGCapabilities.h (97021 => 97022)
--- trunk/Source/_javascript_Core/dfg/DFGCapabilities.h 2011-10-09 07:23:28 UTC (rev 97021)
+++ trunk/Source/_javascript_Core/dfg/DFGCapabilities.h 2011-10-09 08:08:48 UTC (rev 97022)
@@ -33,13 +33,6 @@
#define ENABLE_DFG_RESTRICTIONS 1
-#if USE(JSVALUE64)
-#define ENABLE_DFG_32BIT_RESTRICTIONS 0
-#else
-#define ENABLE_DFG_32BIT_RESTRICTIONS 1
-#endif
-
-
#if ENABLE(DFG_JIT)
// Fast check functions; if they return true it is still necessary to
// check opcodes.
@@ -131,6 +124,8 @@
case op_to_primitive:
case op_throw:
case op_throw_reference_error:
+ case op_call:
+ case op_construct:
return true;
// Opcodes we support conditionally. Enabling these opcodes currently results in
@@ -146,17 +141,6 @@
return true;
#endif
- // Opcodes we support conditionally on 32-bit builds. Enabling these opcodes
- // currently results in crashes, which are still being investigated.
-
- case op_call:
- case op_construct:
-#if ENABLE(DFG_32BIT_RESTRICTIONS)
- return false;
-#else
- return true;
-#endif
-
default:
return false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
