Title: [97023] trunk/Source/WebCore
- Revision
- 97023
- Author
- [email protected]
- Date
- 2011-10-09 03:00:09 -0700 (Sun, 09 Oct 2011)
Log Message
Do not compare the first glyph to itself in Font::drawGlyphBuffer()
https://bugs.webkit.org/show_bug.cgi?id=69715
Reviewed by Andreas Kling.
When looking for glyphs with similar properties, we should
skip the first one since the comparison of fontData
and offset will always fail.
This is covered by the existing tests.
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::drawGlyphBuffer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97022 => 97023)
--- trunk/Source/WebCore/ChangeLog 2011-10-09 08:08:48 UTC (rev 97022)
+++ trunk/Source/WebCore/ChangeLog 2011-10-09 10:00:09 UTC (rev 97023)
@@ -1,3 +1,19 @@
+2011-10-09 Benjamin Poulain <[email protected]>
+
+ Do not compare the first glyph to itself in Font::drawGlyphBuffer()
+ https://bugs.webkit.org/show_bug.cgi?id=69715
+
+ Reviewed by Andreas Kling.
+
+ When looking for glyphs with similar properties, we should
+ skip the first one since the comparison of fontData
+ and offset will always fail.
+
+ This is covered by the existing tests.
+
+ * platform/graphics/FontFastPath.cpp:
+ (WebCore::Font::drawGlyphBuffer):
+
2011-10-08 Justin Schuh <[email protected]>
Make ThreadGlobalData members use OwnPtr
Modified: trunk/Source/WebCore/platform/graphics/FontFastPath.cpp (97022 => 97023)
--- trunk/Source/WebCore/platform/graphics/FontFastPath.cpp 2011-10-09 08:08:48 UTC (rev 97022)
+++ trunk/Source/WebCore/platform/graphics/FontFastPath.cpp 2011-10-09 10:00:09 UTC (rev 97023)
@@ -383,9 +383,9 @@
const SimpleFontData* fontData = glyphBuffer.fontDataAt(0);
FloatSize offset = glyphBuffer.offsetAt(0);
FloatPoint startPoint(point);
- float nextX = startPoint.x();
+ float nextX = startPoint.x() + glyphBuffer.advanceAt(0);
int lastFrom = 0;
- int nextGlyph = 0;
+ int nextGlyph = 1;
#if ENABLE(SVG_FONTS)
TextRun::RenderingContext* renderingContext = run.renderingContext();
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
