Title: [97748] trunk/Source/WebKit2
- Revision
- 97748
- Author
- [email protected]
- Date
- 2011-10-18 07:12:51 -0700 (Tue, 18 Oct 2011)
Log Message
[Qt] Fix linkHoveredDoesntEmitRepeated test in the bot
https://bugs.webkit.org/show_bug.cgi?id=70329
Reviewed by Andreas Kling.
Use LoadSpy::wait() instead of the TestCase::tryCompare(). They should be equivalent,
but I'm getting strange results with tryCompare(). This commit also adds an extra check
to make sure the hovered link is the correct one.
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (97747 => 97748)
--- trunk/Source/WebKit2/ChangeLog 2011-10-18 13:51:48 UTC (rev 97747)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-18 14:12:51 UTC (rev 97748)
@@ -1,3 +1,16 @@
+2011-10-18 Caio Marcelo de Oliveira Filho <[email protected]>
+
+ [Qt] Fix linkHoveredDoesntEmitRepeated test in the bot
+ https://bugs.webkit.org/show_bug.cgi?id=70329
+
+ Reviewed by Andreas Kling.
+
+ Use LoadSpy::wait() instead of the TestCase::tryCompare(). They should be equivalent,
+ but I'm getting strange results with tryCompare(). This commit also adds an extra check
+ to make sure the hovered link is the correct one.
+
+ * UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
+
2011-10-18 Alexis Menard <[email protected]>
[Qt][WK2] Some QML tests were accidentally committed.
Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml (97747 => 97748)
--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml 2011-10-18 13:51:48 UTC (rev 97747)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml 2011-10-18 14:12:51 UTC (rev 97748)
@@ -61,13 +61,15 @@
for (var i = 0; i < 100; i += 10)
mouseMove(webView, 100, 100 + i)
- tryCompare(spy.count, 1)
+ spy.wait()
+ compare(spy.count, 1)
+ compare(webView.lastUrl, Qt.resolvedUrl("../common/test1.html"))
for (var i = 0; i < 100; i += 10)
mouseMove(webView, 100, 300 + i)
spy.wait()
- tryCompare(spy.count, 2)
+ compare(spy.count, 2)
compare(webView.lastUrl, "")
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
