Title: [97749] trunk/Source/WebKit/efl
- Revision
- 97749
- Author
- [email protected]
- Date
- 2011-10-18 07:16:17 -0700 (Tue, 18 Oct 2011)
Log Message
[EFL] Remove const modifier from ctx_menu functions.
https://bugs.webkit.org/show_bug.cgi?id=70090
Patch by Grzegorz Czajkowski <[email protected]> on 2011-10-18
Reviewed by Andreas Kling.
Functions ewk_context_menu_show and ewk_context_menu_custom_get
have got const modifer to ensure that Ewk_Context_Menu won't be
changed. The methods emit events through
evas_object_smart_callback_call with Ewk_Context_Menu as parameter
which is converted to void *. In this case an application which
receives those events may change Ewk_Context_Menu.
Additionaly the name of ewk_context_menu_custom_get has been changed
to ewk_context_menu_customize because an application is able to
modify the items of context menu.
* ewk/ewk_contextmenu.cpp:
(ewk_context_menu_customize):
(ewk_context_menu_show):
* ewk/ewk_private.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (97748 => 97749)
--- trunk/Source/WebKit/efl/ChangeLog 2011-10-18 14:12:51 UTC (rev 97748)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-10-18 14:16:17 UTC (rev 97749)
@@ -1,3 +1,26 @@
+2011-10-18 Grzegorz Czajkowski <[email protected]>
+
+ [EFL] Remove const modifier from ctx_menu functions.
+ https://bugs.webkit.org/show_bug.cgi?id=70090
+
+ Reviewed by Andreas Kling.
+
+ Functions ewk_context_menu_show and ewk_context_menu_custom_get
+ have got const modifer to ensure that Ewk_Context_Menu won't be
+ changed. The methods emit events through
+ evas_object_smart_callback_call with Ewk_Context_Menu as parameter
+ which is converted to void *. In this case an application which
+ receives those events may change Ewk_Context_Menu.
+
+ Additionaly the name of ewk_context_menu_custom_get has been changed
+ to ewk_context_menu_customize because an application is able to
+ modify the items of context menu.
+
+ * ewk/ewk_contextmenu.cpp:
+ (ewk_context_menu_customize):
+ (ewk_context_menu_show):
+ * ewk/ewk_private.h:
+
2011-10-17 Raphael Kubo da Costa <[email protected]>
[EFL] Expose the kit() frame function to the rest of ewk.
Modified: trunk/Source/WebKit/efl/ewk/ewk_contextmenu.cpp (97748 => 97749)
--- trunk/Source/WebKit/efl/ewk/ewk_contextmenu.cpp 2011-10-18 14:12:51 UTC (rev 97748)
+++ trunk/Source/WebKit/efl/ewk/ewk_contextmenu.cpp 2011-10-18 14:16:17 UTC (rev 97749)
@@ -301,7 +301,7 @@
*
* @see ewk_context_menu_item_list_get
*/
-Ewk_Context_Menu* ewk_context_menu_custom_get(const Ewk_Context_Menu* menu)
+Ewk_Context_Menu* ewk_context_menu_customize(Ewk_Context_Menu* menu)
{
EINA_SAFETY_ON_NULL_RETURN_VAL(menu, 0);
@@ -316,7 +316,7 @@
*
* @param o the context menu object
*/
-void ewk_context_menu_show(const Ewk_Context_Menu* menu)
+void ewk_context_menu_show(Ewk_Context_Menu* menu)
{
EINA_SAFETY_ON_NULL_RETURN(menu);
Modified: trunk/Source/WebKit/efl/ewk/ewk_private.h (97748 => 97749)
--- trunk/Source/WebKit/efl/ewk/ewk_private.h 2011-10-18 14:12:51 UTC (rev 97748)
+++ trunk/Source/WebKit/efl/ewk/ewk_private.h 2011-10-18 14:16:17 UTC (rev 97749)
@@ -171,8 +171,8 @@
Ewk_Context_Menu* ewk_context_menu_new(Evas_Object* view, WebCore::ContextMenuController* controller);
Eina_Bool ewk_context_menu_free(Ewk_Context_Menu* o);
void ewk_context_menu_item_append(Ewk_Context_Menu* o, WebCore::ContextMenuItem& core);
-Ewk_Context_Menu* ewk_context_menu_custom_get(const Ewk_Context_Menu* o);
-void ewk_context_menu_show(const Ewk_Context_Menu* o);
+Ewk_Context_Menu* ewk_context_menu_customize(Ewk_Context_Menu* o);
+void ewk_context_menu_show(Ewk_Context_Menu* o);
#endif
const Eina_Rectangle* ewk_view_repaints_get(const Ewk_View_Private_Data* priv, size_t* count);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
