Diff
Modified: trunk/Source/WebCore/ChangeLog (200351 => 200352)
--- trunk/Source/WebCore/ChangeLog 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebCore/ChangeLog 2016-05-03 01:01:53 UTC (rev 200352)
@@ -1,3 +1,21 @@
+2016-05-02 Brady Eidson <[email protected]>
+
+ Const-ify some IDB code.
+ https://bugs.webkit.org/show_bug.cgi?id=157287
+
+ Reviewed by Alex Christensen.
+
+ No new tests (Refactor only).
+
+ * Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
+ * Modules/indexeddb/shared/InProcessIDBServer.cpp:
+ (WebCore::InProcessIDBServer::deleteDatabase):
+ (WebCore::InProcessIDBServer::openDatabase):
+ (WebCore::InProcessIDBServer::abortTransaction):
+ (WebCore::InProcessIDBServer::commitTransaction):
+ (WebCore::InProcessIDBServer::didFinishHandlingVersionChangeTransaction):
+ * Modules/indexeddb/shared/InProcessIDBServer.h:
+
2016-05-02 Antti Koivisto <[email protected]>
REGRESSION(r199964): Animation on pseudo elements doesn't trigger if first frame matches the current style
Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h (200351 => 200352)
--- trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h 2016-05-03 01:01:53 UTC (rev 200352)
@@ -57,11 +57,11 @@
virtual ~IDBConnectionToServerDelegate() { }
virtual uint64_t identifier() const = 0;
- virtual void deleteDatabase(IDBRequestData&) = 0;
- virtual void openDatabase(IDBRequestData&) = 0;
- virtual void abortTransaction(IDBResourceIdentifier&) = 0;
- virtual void commitTransaction(IDBResourceIdentifier&) = 0;
- virtual void didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier&) = 0;
+ virtual void deleteDatabase(const IDBRequestData&) = 0;
+ virtual void openDatabase(const IDBRequestData&) = 0;
+ virtual void abortTransaction(const IDBResourceIdentifier&) = 0;
+ virtual void commitTransaction(const IDBResourceIdentifier&) = 0;
+ virtual void didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier&) = 0;
virtual void createObjectStore(const IDBRequestData&, const IDBObjectStoreInfo&) = 0;
virtual void deleteObjectStore(const IDBRequestData&, const String& objectStoreName) = 0;
virtual void clearObjectStore(const IDBRequestData&, uint64_t objectStoreIdentifier) = 0;
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp (200351 => 200352)
--- trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp 2016-05-03 01:01:53 UTC (rev 200352)
@@ -89,7 +89,7 @@
return *m_connectionToClient;
}
-void InProcessIDBServer::deleteDatabase(IDBRequestData& requestData)
+void InProcessIDBServer::deleteDatabase(const IDBRequestData& requestData)
{
RefPtr<InProcessIDBServer> self(this);
RunLoop::current().dispatch([this, self, requestData] {
@@ -105,7 +105,7 @@
});
}
-void InProcessIDBServer::openDatabase(IDBRequestData& requestData)
+void InProcessIDBServer::openDatabase(const IDBRequestData& requestData)
{
RefPtr<InProcessIDBServer> self(this);
RunLoop::current().dispatch([this, self, requestData] {
@@ -225,7 +225,7 @@
});
}
-void InProcessIDBServer::abortTransaction(IDBResourceIdentifier& resourceIdentifier)
+void InProcessIDBServer::abortTransaction(const IDBResourceIdentifier& resourceIdentifier)
{
RefPtr<InProcessIDBServer> self(this);
RunLoop::current().dispatch([this, self, resourceIdentifier] {
@@ -233,7 +233,7 @@
});
}
-void InProcessIDBServer::commitTransaction(IDBResourceIdentifier& resourceIdentifier)
+void InProcessIDBServer::commitTransaction(const IDBResourceIdentifier& resourceIdentifier)
{
RefPtr<InProcessIDBServer> self(this);
RunLoop::current().dispatch([this, self, resourceIdentifier] {
@@ -241,7 +241,7 @@
});
}
-void InProcessIDBServer::didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier& transactionIdentifier)
+void InProcessIDBServer::didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier& transactionIdentifier)
{
RefPtr<InProcessIDBServer> self(this);
RunLoop::current().dispatch([this, self, transactionIdentifier] {
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h (200351 => 200352)
--- trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h 2016-05-03 01:01:53 UTC (rev 200352)
@@ -55,11 +55,11 @@
IDBServer::IDBConnectionToClient& connectionToClient() const;
// IDBConnectionToServer
- void deleteDatabase(IDBRequestData&) final;
- void openDatabase(IDBRequestData&) final;
- void abortTransaction(IDBResourceIdentifier&) final;
- void commitTransaction(IDBResourceIdentifier&) final;
- void didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier&) final;
+ void deleteDatabase(const IDBRequestData&) final;
+ void openDatabase(const IDBRequestData&) final;
+ void abortTransaction(const IDBResourceIdentifier&) final;
+ void commitTransaction(const IDBResourceIdentifier&) final;
+ void didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier&) final;
void createObjectStore(const IDBRequestData&, const IDBObjectStoreInfo&) final;
void deleteObjectStore(const IDBRequestData&, const String& objectStoreName) final;
void clearObjectStore(const IDBRequestData&, uint64_t objectStoreIdentifier) final;
Modified: trunk/Source/WebKit2/ChangeLog (200351 => 200352)
--- trunk/Source/WebKit2/ChangeLog 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-03 01:01:53 UTC (rev 200352)
@@ -1,3 +1,18 @@
+2016-05-02 Brady Eidson <[email protected]>
+
+ Const-ify some IDB code.
+ https://bugs.webkit.org/show_bug.cgi?id=157287
+
+ Reviewed by Alex Christensen.
+
+ * WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
+ (WebKit::WebIDBConnectionToServer::deleteDatabase):
+ (WebKit::WebIDBConnectionToServer::openDatabase):
+ (WebKit::WebIDBConnectionToServer::abortTransaction):
+ (WebKit::WebIDBConnectionToServer::commitTransaction):
+ (WebKit::WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
+ * WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
+
2016-05-02 Simon Fraser <[email protected]>
Sort the project file.
Modified: trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp (200351 => 200352)
--- trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp 2016-05-03 01:01:53 UTC (rev 200352)
@@ -81,27 +81,27 @@
return *m_connectionToServer;
}
-void WebIDBConnectionToServer::deleteDatabase(IDBRequestData& requestData)
+void WebIDBConnectionToServer::deleteDatabase(const IDBRequestData& requestData)
{
send(Messages::WebIDBConnectionToClient::DeleteDatabase(requestData));
}
-void WebIDBConnectionToServer::openDatabase(IDBRequestData& requestData)
+void WebIDBConnectionToServer::openDatabase(const IDBRequestData& requestData)
{
send(Messages::WebIDBConnectionToClient::OpenDatabase(requestData));
}
-void WebIDBConnectionToServer::abortTransaction(IDBResourceIdentifier& transactionIdentifier)
+void WebIDBConnectionToServer::abortTransaction(const IDBResourceIdentifier& transactionIdentifier)
{
send(Messages::WebIDBConnectionToClient::AbortTransaction(transactionIdentifier));
}
-void WebIDBConnectionToServer::commitTransaction(IDBResourceIdentifier& transactionIdentifier)
+void WebIDBConnectionToServer::commitTransaction(const IDBResourceIdentifier& transactionIdentifier)
{
send(Messages::WebIDBConnectionToClient::CommitTransaction(transactionIdentifier));
}
-void WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier& transactionIdentifier)
+void WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier& transactionIdentifier)
{
send(Messages::WebIDBConnectionToClient::DidFinishHandlingVersionChangeTransaction(transactionIdentifier));
}
Modified: trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h (200351 => 200352)
--- trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h 2016-05-03 01:01:53 UTC (rev 200352)
@@ -45,11 +45,11 @@
uint64_t messageSenderDestinationID() final { return m_identifier; }
// IDBConnectionToServerDelegate
- void deleteDatabase(WebCore::IDBRequestData&) final;
- void openDatabase(WebCore::IDBRequestData&) final;
- void abortTransaction(WebCore::IDBResourceIdentifier&) final;
- void commitTransaction(WebCore::IDBResourceIdentifier&) final;
- void didFinishHandlingVersionChangeTransaction(WebCore::IDBResourceIdentifier&) final;
+ void deleteDatabase(const WebCore::IDBRequestData&) final;
+ void openDatabase(const WebCore::IDBRequestData&) final;
+ void abortTransaction(const WebCore::IDBResourceIdentifier&) final;
+ void commitTransaction(const WebCore::IDBResourceIdentifier&) final;
+ void didFinishHandlingVersionChangeTransaction(const WebCore::IDBResourceIdentifier&) final;
void createObjectStore(const WebCore::IDBRequestData&, const WebCore::IDBObjectStoreInfo&) final;
void deleteObjectStore(const WebCore::IDBRequestData&, const String& objectStoreName) final;
void clearObjectStore(const WebCore::IDBRequestData&, uint64_t objectStoreIdentifier) final;