Title: [200353] trunk/Source/WebInspectorUI
- Revision
- 200353
- Author
- [email protected]
- Date
- 2016-05-02 18:34:32 -0700 (Mon, 02 May 2016)
Log Message
Web Inspector: Unexpected "Script Element #" resources in Debugger Sidebar
https://bugs.webkit.org/show_bug.cgi?id=157280
Patch by Joseph Pecoraro <[email protected]> on 2016-05-02
Reviewed by Timothy Hatcher.
* UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype._addScript):
Don't include Script Element resources in the debugger sidebar by default.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (200352 => 200353)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-03 01:01:53 UTC (rev 200352)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-03 01:34:32 UTC (rev 200353)
@@ -1,5 +1,16 @@
2016-05-02 Joseph Pecoraro <[email protected]>
+ Web Inspector: Unexpected "Script Element #" resources in Debugger Sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=157280
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/DebuggerSidebarPanel.js:
+ (WebInspector.DebuggerSidebarPanel.prototype._addScript):
+ Don't include Script Element resources in the debugger sidebar by default.
+
+2016-05-02 Joseph Pecoraro <[email protected]>
+
Web Inspector: Prefer "Console Evaluation" to "Eval Code" if we know it was a console evaluation
https://bugs.webkit.org/show_bug.cgi?id=157278
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (200352 => 200353)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2016-05-03 01:01:53 UTC (rev 200352)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2016-05-03 01:34:32 UTC (rev 200353)
@@ -451,6 +451,10 @@
if (!script.url && !script.sourceURL)
return null;
+ // In general, do not show dynamically added script elements.
+ if (script.dynamicallyAddedScriptElement && !script.sourceURL)
+ return null;
+
// Don't add breakpoints if the script is represented by a Resource. They were
// already added by _resourceAdded.
if (script.resource)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes