Title: [200355] trunk/Source/_javascript_Core
Revision
200355
Author
[email protected]
Date
2016-05-02 19:00:22 -0700 (Mon, 02 May 2016)

Log Message

Web Inspector: Reflect.toString() should be [object Object] not [object Reflect]
https://bugs.webkit.org/show_bug.cgi?id=157288

Patch by Joseph Pecoraro <[email protected]> on 2016-05-02
Reviewed by Darin Adler.

* runtime/ReflectObject.cpp:
* tests/stress/reflect.js: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (200354 => 200355)


--- trunk/Source/_javascript_Core/ChangeLog	2016-05-03 01:39:50 UTC (rev 200354)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-05-03 02:00:22 UTC (rev 200355)
@@ -1,3 +1,13 @@
+2016-05-02  Joseph Pecoraro  <[email protected]>
+
+        Web Inspector: Reflect.toString() should be [object Object] not [object Reflect]
+        https://bugs.webkit.org/show_bug.cgi?id=157288
+
+        Reviewed by Darin Adler.
+
+        * runtime/ReflectObject.cpp:
+        * tests/stress/reflect.js: Added.
+
 2016-05-02  Jon Davis  <[email protected]>
 
         Add Resource Timing entry to the Feature Status page.

Modified: trunk/Source/_javascript_Core/runtime/ReflectObject.cpp (200354 => 200355)


--- trunk/Source/_javascript_Core/runtime/ReflectObject.cpp	2016-05-03 01:39:50 UTC (rev 200354)
+++ trunk/Source/_javascript_Core/runtime/ReflectObject.cpp	2016-05-03 02:00:22 UTC (rev 200355)
@@ -54,7 +54,7 @@
 
 STATIC_ASSERT_IS_TRIVIALLY_DESTRUCTIBLE(ReflectObject);
 
-const ClassInfo ReflectObject::s_info = { "Reflect", &Base::s_info, &reflectObjectTable, CREATE_METHOD_TABLE(ReflectObject) };
+const ClassInfo ReflectObject::s_info = { "Object", &Base::s_info, &reflectObjectTable, CREATE_METHOD_TABLE(ReflectObject) };
 
 /* Source for ReflectObject.lut.h
 @begin reflectObjectTable

Added: trunk/Source/_javascript_Core/tests/stress/reflect.js (0 => 200355)


--- trunk/Source/_javascript_Core/tests/stress/reflect.js	                        (rev 0)
+++ trunk/Source/_javascript_Core/tests/stress/reflect.js	2016-05-03 02:00:22 UTC (rev 200355)
@@ -0,0 +1,9 @@
+function shouldBe(actual, expected) {
+    if (actual !== expected)
+        throw new Error('bad value: ' + actual);
+}
+
+shouldBe(typeof Reflect, "object");
+shouldBe(Reflect, Reflect);
+shouldBe(Object.getPrototypeOf(Reflect), Object.getPrototypeOf({}));
+shouldBe(Reflect.toString(), "[object Object]");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to