Title: [200356] trunk/Source/WebCore
Revision
200356
Author
[email protected]
Date
2016-05-02 19:17:36 -0700 (Mon, 02 May 2016)

Log Message

REGRESSION: Page layout of Manga/Picture books and all Fixed Layout ePubs corrupted
https://bugs.webkit.org/show_bug.cgi?id=157292
<rdar://problem/25750144>

Reviewed by Tim Horton.

The scroll state restoration fixes caused a regression in UIWebViews.
Code in UIKit checks for a non-zero page scale in a history item, and
r199233 changed the initialization from 0 to 1.

* history/HistoryItem.h: Use 0 instead of 1 as the initial m_scale.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (200355 => 200356)


--- trunk/Source/WebCore/ChangeLog	2016-05-03 02:00:22 UTC (rev 200355)
+++ trunk/Source/WebCore/ChangeLog	2016-05-03 02:17:36 UTC (rev 200356)
@@ -1,3 +1,17 @@
+2016-05-02  Dean Jackson  <[email protected]>
+
+        REGRESSION: Page layout of Manga/Picture books and all Fixed Layout ePubs corrupted
+        https://bugs.webkit.org/show_bug.cgi?id=157292
+        <rdar://problem/25750144>
+
+        Reviewed by Tim Horton.
+
+        The scroll state restoration fixes caused a regression in UIWebViews.
+        Code in UIKit checks for a non-zero page scale in a history item, and
+        r199233 changed the initialization from 0 to 1.
+
+        * history/HistoryItem.h: Use 0 instead of 1 as the initial m_scale.
+
 2016-05-02  Eric Carlson  <[email protected]>
 
         [Mac] AirPlay fails if target is set before AVPlayer has been created

Modified: trunk/Source/WebCore/history/HistoryItem.h (200355 => 200356)


--- trunk/Source/WebCore/history/HistoryItem.h	2016-05-03 02:00:22 UTC (rev 200355)
+++ trunk/Source/WebCore/history/HistoryItem.h	2016-05-03 02:17:36 UTC (rev 200356)
@@ -269,7 +269,7 @@
     FloatSize m_minimumLayoutSizeInScrollViewCoordinates;
     IntSize m_contentSize;
     FloatSize m_obscuredInset;
-    float m_scale { 1 };
+    float m_scale { 0 }; // Note that UIWebView looks for a non-zero value, so this has to start as 0.
     bool m_scaleIsInitial { false };
     ViewportArguments m_viewportArguments;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to