Title: [201499] trunk/Source/WebInspectorUI
- Revision
- 201499
- Author
- [email protected]
- Date
- 2016-05-30 09:56:24 -0700 (Mon, 30 May 2016)
Log Message
Web Inspector: Right-clicking in Snapshot's DataGrid throws an exception
https://bugs.webkit.org/show_bug.cgi?id=157934
<rdar://problem/26380910>
Reviewed by Brian Burg.
Check that click event target is actually a cell, as it can be a row
when focusing the table after dismissing a popup menu.
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (201498 => 201499)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-30 08:14:31 UTC (rev 201498)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-30 16:56:24 UTC (rev 201499)
@@ -1,3 +1,17 @@
+2016-05-30 Matt Baker <[email protected]>
+
+ Web Inspector: Right-clicking in Snapshot's DataGrid throws an exception
+ https://bugs.webkit.org/show_bug.cgi?id=157934
+ <rdar://problem/26380910>
+
+ Reviewed by Brian Burg.
+
+ Check that click event target is actually a cell, as it can be a row
+ when focusing the table after dismissing a popup menu.
+
+ * UserInterface/Views/DataGrid.js:
+ (WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):
+
2016-05-27 Joseph Pecoraro <[email protected]>
Web Inspector: Not all transitively dominated nodes display their retained size
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (201498 => 201499)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-05-30 08:14:31 UTC (rev 201498)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2016-05-30 16:56:24 UTC (rev 201499)
@@ -2466,7 +2466,7 @@
if (!this.hasChildren)
return false;
let cell = event.target.enclosingNodeOrSelfWithNodeName("td");
- if (!cell.classList.contains("disclosure"))
+ if (!cell || !cell.classList.contains("disclosure"))
return false;
let computedLeftPadding = window.getComputedStyle(cell).getPropertyCSSValue("padding-left").getFloatValue(CSSPrimitiveValue.CSS_PX);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
