Title: [201502] trunk/Source/WebInspectorUI
- Revision
- 201502
- Author
- [email protected]
- Date
- 2016-05-30 13:26:25 -0700 (Mon, 30 May 2016)
Log Message
Web Inspector: Uncaught exception page should pre-populate the bug's URL with the inspected page URL
https://bugs.webkit.org/show_bug.cgi?id=158055
<rdar://problem/26516693>
Reviewed by Saam Barati.
* UserInterface/Debug/UncaughtExceptionReporter.js:
Include the encoded URL in the query string if it is not empty.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (201501 => 201502)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-30 19:03:39 UTC (rev 201501)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-30 20:26:25 UTC (rev 201502)
@@ -1,3 +1,14 @@
+2016-05-30 Brian Burg <[email protected]>
+
+ Web Inspector: Uncaught exception page should pre-populate the bug's URL with the inspected page URL
+ https://bugs.webkit.org/show_bug.cgi?id=158055
+ <rdar://problem/26516693>
+
+ Reviewed by Saam Barati.
+
+ * UserInterface/Debug/UncaughtExceptionReporter.js:
+ Include the encoded URL in the query string if it is not empty.
+
2016-05-30 Matt Baker <[email protected]>
Web Inspector: Right-clicking in Snapshot's DataGrid throws an exception
Modified: trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js (201501 => 201502)
--- trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js 2016-05-30 19:03:39 UTC (rev 201501)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js 2016-05-30 20:26:25 UTC (rev 201502)
@@ -147,7 +147,7 @@
dismissErrorSheet();
}
- let inspectedPageURL = "(unknown)";
+ let inspectedPageURL = null;
try {
inspectedPageURL = WebInspector.frameResourceManager.mainFrame.url;
} catch (e) { }
@@ -157,7 +157,7 @@
let encodedBugDescription = encodeURIComponent(`-------
Auto-generated details:
-Inspected URL: ${inspectedPageURL}
+Inspected URL: ${inspectedPageURL || "(unknown)"}
Loading completed: ${!!loadCompleted}
Frontend User Agent: ${window.navigator.userAgent}
Uncaught exceptions:
@@ -172,7 +172,8 @@
Document any additional information that might be useful in resolving the problem, such as screen shots or other included attachments.
`);
let encodedBugTitle = encodeURIComponent(`Uncaught Exception: ${firstException.message}`);
- let prefilledBugReportLink = `https://bugs.webkit.org/enter_bug.cgi?alias=&assigned_to=webkit-unassigned%40lists.webkit.org&attach_text=&blocked=&bug_file_loc=http%3A%2F%2F&bug_severity=Normal&bug_status=NEW&comment=${encodedBugDescription}&component=Web%20Inspector&contenttypeentry=&contenttypemethod=autodetect&contenttypeselection=text%2Fplain&data=""
+ let encodedInspectedURL = encodeURIComponent(inspectedPageURL || "http://");
+ let prefilledBugReportLink = `https://bugs.webkit.org/enter_bug.cgi?alias=&assigned_to=webkit-unassigned%40lists.webkit.org&attach_text=&blocked=&bug_file_loc=${encodedInspectedURL}&bug_severity=Normal&bug_status=NEW&comment=${encodedBugDescription}&component=Web%20Inspector&contenttypeentry=&contenttypemethod=autodetect&contenttypeselection=text%2Fplain&data=""
let detailsForHTML = formattedErrorDetails.map((line) => `<li>${insertWordBreakCharacters(line)}</li>`).join("\n");
let dismissOptionHTML = !loadCompleted ? "" : `<dt>A frivolous exception will not stop me!</dt>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
