Title: [201732] trunk/Source/_javascript_Core
- Revision
- 201732
- Author
- [email protected]
- Date
- 2016-06-06 16:38:48 -0700 (Mon, 06 Jun 2016)
Log Message
Don't reportAbandonedObjectGraph() after throwing out linked code or RegExps.
<https://webkit.org/b/158444>
Unreviewed.
This is a speculative change for iOS performance bots. The calls to reportAbandonedObjectGraph
were basically redundant, since mainframe navigation will cause GC acceleration anyway via
ScriptController.
This appears successful at recovering the ~0.7% regression I could reproduce locally on newer
hardware but it's a bit too noisy to say for sure.
* runtime/VM.cpp:
(JSC::VM::deleteAllLinkedCode):
(JSC::VM::deleteAllRegExpCode):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (201731 => 201732)
--- trunk/Source/_javascript_Core/ChangeLog 2016-06-06 22:33:44 UTC (rev 201731)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-06-06 23:38:48 UTC (rev 201732)
@@ -1,3 +1,21 @@
+2016-06-06 Andreas Kling <[email protected]>
+
+ Don't reportAbandonedObjectGraph() after throwing out linked code or RegExps.
+ <https://webkit.org/b/158444>
+
+ Unreviewed.
+
+ This is a speculative change for iOS performance bots. The calls to reportAbandonedObjectGraph
+ were basically redundant, since mainframe navigation will cause GC acceleration anyway via
+ ScriptController.
+
+ This appears successful at recovering the ~0.7% regression I could reproduce locally on newer
+ hardware but it's a bit too noisy to say for sure.
+
+ * runtime/VM.cpp:
+ (JSC::VM::deleteAllLinkedCode):
+ (JSC::VM::deleteAllRegExpCode):
+
2016-06-06 Skachkov Oleksandr <[email protected]>
[ESNext] Trailing commas in function parameters.
https://bugs.webkit.org/show_bug.cgi?id=158020
Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (201731 => 201732)
--- trunk/Source/_javascript_Core/runtime/VM.cpp 2016-06-06 22:33:44 UTC (rev 201731)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp 2016-06-06 23:38:48 UTC (rev 201732)
@@ -549,7 +549,6 @@
{
whenIdle([this]() {
heap.deleteAllCodeBlocks();
- heap.reportAbandonedObjectGraph();
});
}
@@ -557,7 +556,6 @@
{
whenIdle([this]() {
m_regExpCache->deleteAllCode();
- heap.reportAbandonedObjectGraph();
});
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
