Title: [201733] trunk/Source/_javascript_Core
Revision
201733
Author
[email protected]
Date
2016-06-06 17:00:55 -0700 (Mon, 06 Jun 2016)

Log Message

32-bit JSC stress test failing: stress/recursive-try-catch.js.ftl-no-cjit-validate-sampling-profiler
https://bugs.webkit.org/show_bug.cgi?id=158362

Reviewed by Michael Saboff.

The test does infinite recursion until it overflows the stack.  That means the
sampling profiler will have to capture excessively large samples, which in turn
makes it run very slowly.  This is what causes the test time out.

The fix is to not run the test with the sampling profiler.

* tests/stress/recursive-try-catch.js:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (201732 => 201733)


--- trunk/Source/_javascript_Core/ChangeLog	2016-06-06 23:38:48 UTC (rev 201732)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-06-07 00:00:55 UTC (rev 201733)
@@ -1,3 +1,18 @@
+2016-06-06  Mark Lam  <[email protected]>
+
+        32-bit JSC stress test failing: stress/recursive-try-catch.js.ftl-no-cjit-validate-sampling-profiler
+        https://bugs.webkit.org/show_bug.cgi?id=158362
+
+        Reviewed by Michael Saboff.
+
+        The test does infinite recursion until it overflows the stack.  That means the
+        sampling profiler will have to capture excessively large samples, which in turn
+        makes it run very slowly.  This is what causes the test time out.
+
+        The fix is to not run the test with the sampling profiler.
+
+        * tests/stress/recursive-try-catch.js:
+
 2016-06-06  Andreas Kling  <[email protected]>
 
         Don't reportAbandonedObjectGraph() after throwing out linked code or RegExps.

Modified: trunk/Source/_javascript_Core/tests/stress/recursive-try-catch.js (201732 => 201733)


--- trunk/Source/_javascript_Core/tests/stress/recursive-try-catch.js	2016-06-06 23:38:48 UTC (rev 201732)
+++ trunk/Source/_javascript_Core/tests/stress/recursive-try-catch.js	2016-06-07 00:00:55 UTC (rev 201733)
@@ -1,3 +1,4 @@
+//@ defaultNoSamplingProfilerRun
 // This test should run to completion without excessive memory usage
 
 let maxHeapAllowed = 10 * 1024 * 1024; // This test should run using much less than 10MB.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to